Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Show QNS results relative to main #2220

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

larseggert
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.39%. Comparing base (b61136f) to head (fbf56ba).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2220   +/-   ##
=======================================
  Coverage   95.39%   95.39%           
=======================================
  Files         112      112           
  Lines       36447    36449    +2     
=======================================
+ Hits        34767    34770    +3     
+ Misses       1680     1679    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Nov 6, 2024

Benchmark results

Performance differences relative to 5d8651a.

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [98.708 ns 99.057 ns 99.413 ns]
       change: [-0.2257% +0.3027% +0.9152%] (p = 0.33 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
12 (12.00%) high mild
4 (4.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [116.65 ns 116.96 ns 117.30 ns]
       change: [-0.5003% -0.1183% +0.2648%] (p = 0.55 > 0.05)

Found 14 outliers among 100 measurements (14.00%)
1 (1.00%) low severe
2 (2.00%) low mild
3 (3.00%) high mild
8 (8.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.51 ns 116.99 ns 117.55 ns]
       change: [-0.5998% -0.1218% +0.3952%] (p = 0.64 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
3 (3.00%) low severe
1 (1.00%) low mild
7 (7.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [97.412 ns 97.608 ns 97.863 ns]
       change: [-1.3165% -0.4269% +0.3787%] (p = 0.36 > 0.05)

Found 11 outliers among 100 measurements (11.00%)
4 (4.00%) high mild
7 (7.00%) high severe

RxStreamOrderer::inbound_frame(): Change within noise threshold.
       time:   [112.50 ms 112.64 ms 112.86 ms]
       change: [+0.1264% +0.3678% +0.6082%] (p = 0.00 < 0.05)

Found 11 outliers among 100 measurements (11.00%)
8 (8.00%) low mild
2 (2.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: No change in performance detected.
       time:   [26.312 ms 27.204 ms 28.083 ms]
       change: [-4.4149% +0.5710% +6.1438%] (p = 0.83 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected.
       time:   [35.007 ms 36.940 ms 38.881 ms]
       change: [-4.5738% +2.7223% +10.317%] (p = 0.48 > 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) low mild
1 (1.00%) high mild

transfer/pacing-false/same-seed: No change in performance detected.
       time:   [25.390 ms 26.250 ms 27.108 ms]
       change: [-6.8216% -2.7094% +1.6159%] (p = 0.19 > 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

transfer/pacing-true/same-seed: No change in performance detected.
       time:   [41.503 ms 43.521 ms 45.567 ms]
       change: [-1.6174% +5.0376% +11.885%] (p = 0.14 > 0.05)
1-conn/1-100mb-resp/mtu-1500 (aka. Download)/client: No change in performance detected.
       time:   [923.06 ms 932.09 ms 941.16 ms]
       thrpt:  [106.25 MiB/s 107.29 MiB/s 108.34 MiB/s]
change:
       time:   [-0.6710% +0.6198% +1.9027%] (p = 0.36 > 0.05)
       thrpt:  [-1.8672% -0.6159% +0.6755%]
1-conn/10_000-parallel-1b-resp/mtu-1500 (aka. RPS)/client: No change in performance detected.
       time:   [317.49 ms 320.60 ms 323.76 ms]
       thrpt:  [30.887 Kelem/s 31.191 Kelem/s 31.497 Kelem/s]
change:
       time:   [-1.9016% -0.5500% +0.7698%] (p = 0.43 > 0.05)
       thrpt:  [-0.7639% +0.5530% +1.9384%]

Found 3 outliers among 100 measurements (3.00%)
1 (1.00%) low mild
2 (2.00%) high mild

1-conn/1-1b-resp/mtu-1500 (aka. HPS)/client: No change in performance detected.
       time:   [33.670 ms 33.812 ms 33.956 ms]
       thrpt:  [29.450  elem/s 29.576  elem/s 29.700  elem/s]
change:
       time:   [-0.7943% -0.0583% +0.6742%] (p = 0.88 > 0.05)
       thrpt:  [-0.6697% +0.0584% +0.8007%]

Found 10 outliers among 100 measurements (10.00%)
6 (6.00%) low mild
2 (2.00%) high mild
2 (2.00%) high severe

1-conn/1-100mb-resp/mtu-1500 (aka. Upload)/client: Change within noise threshold.
       time:   [1.7514 s 1.7717 s 1.7922 s]
       thrpt:  [55.798 MiB/s 56.443 MiB/s 57.097 MiB/s]
change:
       time:   [+0.8611% +2.5486% +4.3065%] (p = 0.00 < 0.05)
       thrpt:  [-4.1287% -2.4853% -0.8537%]

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild

1-conn/1-100mb-resp/mtu-65536 (aka. Download)/client: Change within noise threshold.
       time:   [112.92 ms 113.16 ms 113.41 ms]
       thrpt:  [881.79 MiB/s 883.68 MiB/s 885.61 MiB/s]
change:
       time:   [+0.2464% +0.5912% +0.9268%] (p = 0.00 < 0.05)
       thrpt:  [-0.9183% -0.5877% -0.2458%]
1-conn/10_000-parallel-1b-resp/mtu-65536 (aka. RPS)/client: No change in performance detected.
       time:   [314.55 ms 318.11 ms 321.65 ms]
       thrpt:  [31.089 Kelem/s 31.436 Kelem/s 31.792 Kelem/s]
change:
       time:   [-1.1013% +0.4614% +2.0105%] (p = 0.56 > 0.05)
       thrpt:  [-1.9708% -0.4593% +1.1136%]
1-conn/1-1b-resp/mtu-65536 (aka. HPS)/client: No change in performance detected.
       time:   [33.904 ms 34.094 ms 34.303 ms]
       thrpt:  [29.152  elem/s 29.330  elem/s 29.495  elem/s]
change:
       time:   [-1.0282% -0.1630% +0.6278%] (p = 0.71 > 0.05)
       thrpt:  [-0.6239% +0.1632% +1.0388%]

Found 6 outliers among 100 measurements (6.00%)
1 (1.00%) low mild
2 (2.00%) high mild
3 (3.00%) high severe

1-conn/1-100mb-resp/mtu-65536 (aka. Upload)/client: No change in performance detected.
       time:   [261.26 ms 306.95 ms 369.24 ms]
       thrpt:  [270.83 MiB/s 325.78 MiB/s 382.77 MiB/s]
change:
       time:   [-20.818% +0.9405% +31.505%] (p = 0.95 > 0.05)
       thrpt:  [-23.957% -0.9317% +26.292%]

Found 7 outliers among 100 measurements (7.00%)
4 (4.00%) high mild
3 (3.00%) high severe

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms] Relative
msquic msquic 1504 168.5 ± 97.9 91.7 415.2 1.00
neqo msquic reno on 1504 215.6 ± 11.6 204.8 233.6 1.00
neqo msquic reno 1504 287.5 ± 98.9 205.1 478.0 1.00
neqo msquic cubic on 1504 253.5 ± 73.4 212.1 484.7 1.00
neqo msquic cubic 1504 262.1 ± 78.8 210.1 436.2 1.00
msquic neqo reno on 1504 785.7 ± 99.2 688.7 945.5 1.00
msquic neqo reno 1504 727.5 ± 40.3 698.9 835.1 1.00
msquic neqo cubic on 1504 767.9 ± 121.6 712.4 1112.5 1.00
msquic neqo cubic 1504 770.4 ± 69.9 712.1 916.0 1.00
neqo neqo reno on 1504 416.4 ± 9.8 402.6 429.5 1.00
neqo neqo reno 1504 460.5 ± 73.9 415.4 668.6 1.00
neqo neqo cubic on 1504 441.8 ± 13.6 429.1 467.1 1.00
neqo neqo cubic 1504 456.2 ± 15.6 430.6 487.5 1.00
msquic msquic 65536 136.8 ± 81.3 93.6 361.3 1.00
neqo msquic reno on 65536 214.5 ± 12.7 199.8 237.0 1.00
neqo msquic reno 65536 282.1 ± 82.4 212.2 408.0 1.00
neqo msquic cubic on 65536 248.2 ± 73.2 201.7 428.3 1.00
neqo msquic cubic 65536 213.2 ± 12.1 199.3 231.2 1.00
msquic neqo reno on 65536 175.8 ± 98.1 93.5 384.5 1.00
msquic neqo reno 65536 147.9 ± 91.3 84.5 412.2 1.00
msquic neqo cubic on 65536 133.9 ± 99.4 82.3 523.2 1.00
msquic neqo cubic 65536 136.7 ± 77.2 82.3 328.6 1.00
neqo neqo reno on 65536 143.2 ± 15.0 127.5 175.9 1.00
neqo neqo reno 65536 200.7 ± 87.7 126.9 415.5 1.00
neqo neqo cubic on 65536 188.2 ± 76.2 123.6 402.2 1.00
neqo neqo cubic 65536 216.9 ± 102.4 111.7 423.1 1.00

⬇️ Download logs

Copy link

github-actions bot commented Nov 6, 2024

Failed Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

  • neqo-latest vs. aioquic: run cancelled after 20 min
  • neqo-latest vs. go-x-net: run cancelled after 20 min
  • neqo-latest vs. haproxy: run cancelled after 20 min
  • neqo-latest vs. msquic: run cancelled after 20 min
  • neqo-latest vs. mvfst: run cancelled after 20 min
  • neqo-latest vs. neqo: run cancelled after 20 min
  • neqo-latest vs. ngtcp2: run cancelled after 20 min
  • neqo-latest vs. picoquic: run cancelled after 20 min
  • neqo-latest vs. quic-go: run cancelled after 20 min
  • neqo-latest vs. quiche: run cancelled after 20 min
  • neqo-latest vs. quinn: run cancelled after 20 min
  • neqo-latest vs. s2n-quic: run cancelled after 20 min
  • neqo-latest vs. xquic: run cancelled after 20 min

neqo-latest as server

  • aioquic vs. neqo-latest: run cancelled after 20 min
  • chrome vs. neqo-latest: run cancelled after 20 min
  • lsquic vs. neqo-latest: run cancelled after 20 min
  • msquic vs. neqo-latest: run cancelled after 20 min
  • mvfst vs. neqo-latest: Z A L1 C1
  • ngtcp2 vs. neqo-latest: run cancelled after 20 min
  • picoquic vs. neqo-latest: run cancelled after 20 min
  • quic-go vs. neqo-latest: run cancelled after 20 min
  • quiche vs. neqo-latest: run cancelled after 20 min
  • quinn vs. neqo-latest: run cancelled after 20 min
  • s2n-quic vs. neqo-latest: run cancelled after 20 min
  • xquic vs. neqo-latest: run cancelled after 20 min
All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant