Qlog 0 2 mystery #518
Closed
Qlog 0 2 mystery #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional qlog context when creating a Connection. Pass qlog context into Connection from neqo-client. Add cmdline option to save qlog to a file. Implement initial trace hooks for client connected start and packet received. Still a lot more to do. Pull out frame and pkt type conversion into helper functions. Move stuff into common and implement server logging on connection close Move Role and a little qlog stuff into common. Server: Catch the connection closed event and use that to generate qlog output. Get the connection ID so we can write separate logs for each server connection.
In order to include a NeqoQlogRef (and by extension a NeqoQlog) in a struct that derives Debug, NeqoQlog must itself implement the Debug trait.
Propogate optional NeqoQlogRefs to the various Http3 subsystems for them to use and (perhaps) pass to the connections and other components that they instantiate that can log qlog data.
Add optional NeqoQlogRefs as fields in the Encoder and Decoder structures. Also update the parameters to their new() functions for setting those fields.
Besides refactoring, there are several other changes: 1. Add a test 2. Fix the implementation to match the current qlog spec for formatting a number as a hexadecimal string.
agrover
added
bug
|
This is with either rustc 1.41.1 or 1.42, btw. |
|
It's this: rust-lang/rust#46257 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working on rebasing our in-progress qlog PR (473) and also moving to qlog 0.2.0 crate version. In doing so I'm having some extreme weirdness. The changes needed for qlog 0.2 are nothing special, but for some reason cause two other, seemingly-unrelated spots of our code to start throwing errors!
What's going on here?