Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QNS server: Support test cases requiring HTTP 0.9 #815

Merged
merged 6 commits into from
Jul 14, 2020

Conversation

agrover
Copy link
Contributor

@agrover agrover commented Jul 14, 2020

For qns mode, we need to support HTTP/0.9. Instead of adding qns mode to
http server, I added H/0.9 to http3-server, since it already supports
transport::Server, and has a more developed event loop.

Add a 'HttpServer' trait that is implemented by Http3Server and
Http09Server.

Implement Http09Server. Add a DenyZeroRttChecker since Server requires one
be passed in.

@agrover agrover requested review from vonasek and ddragana July 14, 2020 00:07
@agrover agrover force-pushed the qns-server-transfer branch from e928348 to abc3a89 Compare July 14, 2020 00:18
Andy Grover added 3 commits July 13, 2020 19:43
For qns mode, we need to support HTTP/0.9. Instead of adding qns mode to
http server, I added H/0.9 to http3-server, since it already supports
transport::Server, and has a more developed event loop.

Add a 'HttpServer' trait that is implemented by Http3Server and
Http09Server.

Implement Http09Server. Add a DenyZeroRttChecker since Server requires one
be passed in.
@agrover agrover force-pushed the qns-server-transfer branch from abc3a89 to 906c3f0 Compare July 14, 2020 03:04
@agrover agrover requested a review from martinthomson July 14, 2020 03:06
@agrover agrover linked an issue Jul 14, 2020 that may be closed by this pull request
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Land after fixing.

neqo-http3-server/src/main.rs Outdated Show resolved Hide resolved
neqo-http3-server/src/main.rs Outdated Show resolved Hide resolved
neqo-http3-server/src/main.rs Outdated Show resolved Hide resolved
neqo-http3-server/src/old_https.rs Outdated Show resolved Hide resolved
neqo-http3-server/src/old_https.rs Show resolved Hide resolved
@agrover agrover force-pushed the qns-server-transfer branch from 89ab5c2 to aef60d3 Compare July 14, 2020 16:47
@agrover agrover force-pushed the qns-server-transfer branch from aef60d3 to 33a9b9b Compare July 14, 2020 16:48
@agrover
Copy link
Contributor Author

agrover commented Jul 14, 2020

Merging based on reviewer approval w changes.

@agrover agrover merged commit d09cd9f into mozilla:master Jul 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neqo-server: implement "transfer" test case
2 participants