-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QNS server: Support test cases requiring HTTP 0.9 #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agrover
force-pushed
the
qns-server-transfer
branch
from
July 14, 2020 00:18
e928348
to
abc3a89
Compare
For qns mode, we need to support HTTP/0.9. Instead of adding qns mode to http server, I added H/0.9 to http3-server, since it already supports transport::Server, and has a more developed event loop. Add a 'HttpServer' trait that is implemented by Http3Server and Http09Server. Implement Http09Server. Add a DenyZeroRttChecker since Server requires one be passed in.
Accept 0-RTT.
agrover
force-pushed
the
qns-server-transfer
branch
from
July 14, 2020 03:04
abc3a89
to
906c3f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Land after fixing.
agrover
force-pushed
the
qns-server-transfer
branch
from
July 14, 2020 16:47
89ab5c2
to
aef60d3
Compare
To reduce main()'s complexity.
agrover
force-pushed
the
qns-server-transfer
branch
from
July 14, 2020 16:48
aef60d3
to
33a9b9b
Compare
Merging based on reviewer approval w changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For qns mode, we need to support HTTP/0.9. Instead of adding qns mode to
http server, I added H/0.9 to http3-server, since it already supports
transport::Server, and has a more developed event loop.
Add a 'HttpServer' trait that is implemented by Http3Server and
Http09Server.
Implement Http09Server. Add a DenyZeroRttChecker since Server requires one
be passed in.