Bump commander from v2 to v12 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
fregante
commented
Aug 4, 2024
•
fregante
commented
- closes Dependencies cleanup targeting the next major version bump #89
fregante
commented
Aug 4, 2024
|
|
||
| program | ||
| .command("start") | ||
| .description("Start Firefox") |
There was a problem hiding this comment.
.option() must now follow .command()
| .command("start") | ||
| .description("Start Firefox") | ||
| .action(function() { | ||
| console.log(Object.keys(program)) |
There was a problem hiding this comment.
The test harness relied on program being outputted to the user. Commander no longer applies the flags to program and they no longer appear as --flags anymore, so the test had to be updated.
I made two changes:
- the user no longer sees this noise, it's hidden behind a fx-runner-specific ENV
- instead of looking for random flags, it matches against the whole
parsedOptionsobject. This ensures that the additional logic in this object can also be tested.
This was referenced Aug 4, 2024
Rob--W
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.