Add firefoxdeveloperedition alias on Linux

[ariasuni]

There is at least one distribution, Arch Linux, which is using firefox-developer-edition as an executable name, and this is coherent with the other aliases:

https://github.com/mozilla-jetpack/node-fx-runner/blob/e72b066326e1abd0cd1a4a0d556daf1e6bcc2370/lib/utils.js#L121-L123

[Rob--W]

There is at least one distribution, Arch Linux, which is using firefox-developer-edition as an executable name, and this is coherent with the other aliases:

https://github.com/mozilla-jetpack/node-fx-runner/blob/e72b066326e1abd0cd1a4a0d556daf1e6bcc2370/lib/utils.js#L121-L123

If for consistency, the name would be developeredition or developer-edition, not firefoxdeveloperedition.

I see that your suggestion makes sense for macOS though.

But as I suggested in #43, adding another alias, deved, would probably help. I mean, my use case is to be able to type web-ext run -f deved, and with the current proposal it would be web-ext run -f firefoxdeveloperedition, which is hardly better than web-ext run -f firefox-developer-edition.

[ariasuni]

Well since firefoxdeveloperedition is present in the doc, it’s annoying that it sometimes doesn’t work, or that I need to change instructions depending on platform (I use web-ext to develop my Firefox extension and I wrote a contributing guide), etc.

I’m fine with changing this PR to use another alias, as discussed in #43.

[Rob--W]

I discussed with @rpl . Let's do firefoxdeveloperedition because it is already used on macos, and add a deved alias that expands to firefoxdeveloperedition.

[ariasuni]

What do you mean by expand? Should I write something like:

if (binaryPath === "deved") {
  binaryPath = "firefoxdeveloperedition";
}

[Rob--W]

Yes, exactly. The other aliases (firefox, beta, nightly) are relatively short, and I would also like to have a similarly concise alias for developer edition.

[Rob--W]

Thanks for this!

I will discuss this PR next week, to prepare a new release and include it in web-ext.

[ariasuni]

Hi, just a reminder that you said:

I will discuss this PR next week, to prepare a new release and include it in web-ext.

[Rob--W]

Thanks for the reminder. Although there haven't been updates here, we do still plan to bump the version for inclusion in web-ext.

We haven't bumped the version yet because there is some opportunity for non-critical improvements in this project (e.g. dependency updates and fixing links/images in the README). Addressing that is a nice-to-have (but not blocking the release) and not a high priority.