Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe actions should not be editable after a recipe is created #600

Open
Osmose opened this issue Mar 9, 2017 · 5 comments
Open

Recipe actions should not be editable after a recipe is created #600

Osmose opened this issue Mar 9, 2017 · 5 comments
Assignees
Labels
improvement P1 - High Priority We're working on this now

Comments

@Osmose
Copy link
Contributor

Osmose commented Mar 9, 2017

#599, #584 and #586 all involve adding server-side behavior that is custom to a specific type of action, and there's potentially confusing edge cases for recipes that change their action. I can't think of a compelling reason to allow users to edit the recipe action after a recipe has been created anyway; they should just create a brand new recipe instead.

@MattGrimes @gregglind @mythmon Thoughts? Objections?

@mythmon
Copy link
Contributor

mythmon commented Mar 28, 2017

This isn't something we need for preference experiments.

@andymikulski
Copy link
Contributor

This is a pretty simple one-liner to implement*. The only question I have is could the user change the action when cloning? Pending this feature's approval, this should be a quick fix.

*<ActionSelect disabled={isLoading || recipe.getIn(['action', 'id'])} />

@Osmose
Copy link
Contributor Author

Osmose commented Aug 14, 2017

  1. I think cloning should be able to change the action.
  2. In a separate PR from the proposed change, I think we want to disallow this on the server side as well as on the client. The eventual goal is to modify our data model to make per-action customization easy.

@MattGrimes
Copy link

+1 to osmose

@mythmon mythmon added P3 We'll work on this in the future improvement and removed status: needs approval labels Jan 30, 2018
@mythmon
Copy link
Contributor

mythmon commented Feb 21, 2018

I think this is both a front-end and back-end issue. The UI should be nice and not expose changing the action after the recipe is created, but also the backend shouldn't allow it, even if the UI does.

@jaredlockhart jaredlockhart removed this from the Backlog milestone Apr 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement P1 - High Priority We're working on this now
Projects
None yet
Development

No branches or pull requests

8 participants