Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe validation depending on its action #599

Closed
Osmose opened this issue Mar 8, 2017 · 3 comments
Closed

Recipe validation depending on its action #599

Osmose opened this issue Mar 8, 2017 · 3 comments
Assignees

Comments

@Osmose
Copy link
Contributor

Osmose commented Mar 8, 2017

@gregglind wants some requirements in place for editing preference experiments:

  • Once published, users should be unable to modify the branches of a feature experiment. If they want to add new feature branches, they need to launch a new experiment.
  • Feature branch slugs should be unique within an experiment.
  • Experiment slugs should be unique.

To support this, we need to be able to validate recipes different depending on their action type.

@mythmon
Copy link
Contributor

mythmon commented Mar 28, 2017

Feature branch slugs should be unique within an experiment.

Should feature branch values also be unique within an experiment?

@gregglind
Copy link
Contributor

gregglind commented Mar 28, 2017 via email

mythmon added a commit to mythmon/normandy that referenced this issue Mar 29, 2017
@Osmose Osmose modified the milestones: Sprint 8 - March 20th to April 1st, Sprint 9 - April 3rd, 2017 to April 15th, 2017 Apr 3, 2017
@mythmon
Copy link
Contributor

mythmon commented Apr 10, 2017

Fixed by #651.

@mythmon mythmon closed this as completed Apr 10, 2017
@mythmon mythmon modified the milestones: Sprint 9 - April 3rd, 2017 to April 14th, 2017, preference-experiments Jan 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants