Skip to content
This repository has been archived by the owner on Jan 6, 2023. It is now read-only.

Pasting inserts extra spaces #127

Closed
johngruen opened this issue Jul 7, 2017 · 10 comments
Closed

Pasting inserts extra spaces #127

johngruen opened this issue Jul 7, 2017 · 10 comments
Labels
Firefox Bug Firefox changes required to implement
Milestone

Comments

@johngruen
Copy link
Contributor

screen shot 2017-07-07 at 4 20 09 pm

becomes

notSupportedHeader = Your browser is not supported.

notSupportedHeader = Unfortunately this browser does not support the web technology that powers Firefox Send. You'll need to try another browser. We recommend Firefox!

// Note Firefox name should not be localized in button, but subhead should

downloadFirefoxButtonSub = Free Download

// note the sentence lower on this page is the same as uploadPageExplainer. Also the link on this page should be removed as Send wont work on this browser anyway

when copy pasted

@johngruen johngruen modified the milestones: Stretch, Launch Jul 7, 2017
@Natim
Copy link
Collaborator

Natim commented Jul 10, 2017

Copy/paste from where?

If I copy/paste the content below to the sidebar, I don't have an issue.

downloadingPageHeader = Downloading {filename] ({size})
downloadingPageMessage = Please leave this tab open while we fetch your file and decrypt it.

errorPageHeader = Something went wrong!
errorPageMessage = There has been an error transferring your file and this connection has been closed. Your friend will have to try again and send you a new link.
errorPageLink = Send another file

expiredPageHeader = This link has expired or never existed in the first place!
// note the sentence lower on this page is the same as uploadPageExplainer, so we can recycle that key

@Natim
Copy link
Collaborator

Natim commented Jul 10, 2017

Ok, I got it, copy pasting from the pad to the github textarea does add newlines for each paragraph:

downloadingPageHeader = Downloading {filename] ({size})

downloadingPageMessage = Please leave this tab open while we fetch your file and decrypt it.


errorPageHeader = Something went wrong!

errorPageMessage = There has been an error transferring your file and this connection has been closed. Your frind will have to try again and send you a new link.

errorPageLink = Send another file


expiredPageHeader = This link has expired or never existed in the first place!

// note the sentence lower on this page is the same as uploadPageExplainer, so we can recycle that key

@Natim
Copy link
Collaborator

Natim commented Jul 10, 2017

Refs slab/quill#1579

@Natim
Copy link
Collaborator

Natim commented Jul 10, 2017

My understanding is that it is the OS copy/paste behaviour to convert <p> as \n\n I have no idea if we can do something about it at our level.

@Natim Natim added the Firefox Bug Firefox changes required to implement label Jul 10, 2017
@Natim Natim modified the milestones: Stretch, Launch Jul 10, 2017
@Natim Natim added the wontfix label Jul 10, 2017
@Natim Natim closed this as completed Jul 10, 2017
@Natim
Copy link
Collaborator

Natim commented Jul 10, 2017

That's the implemented behaviour when pasting HTML in a text area.
The only thing we could try to do is to use <br> instead of <p> when pressing enter. Refs slab/quill#252

@Natim
Copy link
Collaborator

Natim commented Jul 10, 2017

This could be a workable solution: slab/quill#252 (comment)

@Natim Natim reopened this Jul 10, 2017
@Natim Natim removed the wontfix label Jul 10, 2017
@ghost ghost modified the milestones: Launch, Stretch Jul 10, 2017
@Natim
Copy link
Collaborator

Natim commented Jul 10, 2017

The idea is that if you copy something from a textarea/notepad in the pad and then copy it back in the textarea/notepad you should have the same presentation.

In order to do that we need to handle <br/> as well as <p> @ryanfeeley suggested that we handle br on shift+p which is what I have started in #131

We also need to make sure that a paste in the pad uses <br/> whenever necessary.

@Natim
Copy link
Collaborator

Natim commented Jul 18, 2017

It appears that we can't reproduce the bug with Chrome and it might be a Firefox Bug.

@Natim
Copy link
Collaborator

Natim commented Jul 18, 2017

This is the bug that implemented the behaviour: https://bugzilla.mozilla.org/show_bug.cgi?id=1119503

@Natim
Copy link
Collaborator

Natim commented Jul 18, 2017

Ok I found out how to fix this: slab/quill#861

Natim pushed a commit that referenced this issue Jul 18, 2017
@Natim Natim closed this as completed in 15bc022 Jul 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Firefox Bug Firefox changes required to implement
Projects
None yet
Development

No branches or pull requests

2 participants