You are wrongly logged out from "Firefox Notes" after reopening the sidebar if a sync action was previously performed

[Softvision-MariusComan]

[Affected versions]:

• Firefox 59.0.1 and above

[Affected Platforms]:

• All Windows
• All Mac
• All Linux

[Prerequisites]:

• Have a Firefox profile with the latest version of the "Firefox Notes" add-on (3.2.0dev custom built on 2018-03-26) installed.
• You are logged into "Firefox Notes".
• Have ~20 notes in the sidebar.

[Steps to reproduce]:

1. Open the browser with the profile from prerequisites.
2. Click the "Sync Your Notes" button.
3. Close and reopen the sidebar.
4. Observe the bottom toolbar.

[Expected result]:

• The "Synced at (hour) message is displayed.

[Actual result]:

• You are logged out and the "Sign in to Sync" message is displayed.

[Notes]:

• The issue is also reproducible if the sidebar is switched/closed while the "Syncing changes..." message is displayed.
• The issue is still reproducible after restart.
• Attached a screen recording of the issue:
  

[vladikoff]

Right, if there is an error with sync we don't show an error and then just lose the state, Ref: #791 (comment)

[sebastienbarbier]

@ryanfeeley can you suggest a UI for an error notification ?

We asked ourself where an alert would shows up :

However I don't think we can change the title: "The page at moz-extension:xxx-xxxx..."

[vladikoff]

@ryanfeeley can we reuse footer notifications for this, and could you please provide text/copy for this?

[ryanfeeley]

@vladikoff Something like:

Oops! Something went wrong with syncing your Firefox Notes, and you were signed out. Sign in to Sync from within Notes to resume syncing.
OK

[ryanfeeley]

@vladikoff @sebastienbarbier Is that dialog copy + the Reconnect to Sync footer style appropriate?