include strangeness

[jmls]

I have a set of model data, where 3 of the model properties as has the property ui set to true. I also have this code:

radio.html

<p>radio.html: {$ property.name $}</p>

{% asyncEach property in model.properties %}
  {% if property.ui %}
  <h4>has ui</h4>
  {% endif %}
  {% include "views/input/radio.html" %}
{% endeach %}

I get this rendered:

I see all of the property names, and the "has ui" for the three that have the property ui set to true.

so, now I only want the radio.html included if the ui option is set, so I move the include to within the {% if .. %}

{% asyncEach property in model.properties %}
  {% if property.ui %}
  <h4>has ui</h4>
  {% include "views/input/radio.html" %}
  {% endif %}

{% endeach %}

but all I get now is

so, the if is definitely working (I get the "has ui" , but the include contents are not included

am I doing something wrong, or is there a bug here ?

[jmls]

ping ? anyone ? This is really starting to bite me :(
thanks

[devoidfury]

I'm not sure about the include, but you should be able to change it to a macro and solve your issue. They have better repetitive/scope handling:

radio.html

{% macro radio(property) %}
<p>radio.html: {{ property.name }}</p>
{% endmacro %}

otherfile.html

{% include "views/input/radio.html" %}
{% asyncEach property in model.properties %}
  {% if property.ui %}
  <h4>has ui</h4>
  {{ radio(property) }}
  {% endif %}
{% endeach %}

[jmls]

thanks for the feedback - unfortunately, this workaround won't help - I think it's a problem with async in general. I am using a template loader where the template is grabbed from a db record.

I also have several dozen templates that may be needed, each one specified by a property in the data object - and I actually don't know the names (these templates are / can be user-defined)

thanks again for the clever workaround though

[jlongster]

Sorry, this is most likely a bug with async rendering. Async is somewhat experimental, but I doubt this is hard to fix. I'll take a look soon.

[jmls]

I think I've solved the problem. While looking through the parser.js source, I came across this code

parseIf: function() {
        var tag = this.peekToken();
        var node;

        if(this.skipSymbol('if') || this.skipSymbol('elif')) {
            node = new nodes.If(tag.lineno, tag.colno);
        }
        else if(this.skipSymbol('ifAsync')) {
            node = new nodes.IfAsync(tag.lineno, tag.colno);

so I thought i'd try using this mysteriously undocumented ifAsync ;) and it worked ...

{% asyncEach property in model.properties %}
  {% ifAsync property.ui %}
  <h4>has ui</h4>
  {% include "views/input/radio.html" %}
  {% endif %}

{% endeach %}

and I got the desired results

is it ok to use ifAsync - or should if get converted to ifAsync automatically ?

I also seem to have a problem with filters, i'll look into that as well

[jlongster]

@jmls Sorry I haven't looked at this until now. It definitely should automatically be converted into ifAsync in transformer.js. To be clear, you are using an async loader?

[jlongster]

@jmls Make sure you marked your loader as async: http://mozilla.github.io/nunjucks/api.html#asynchronous

[jlongster]

Try it now! It should work

[carljm]

The fix here seems wrong to me on its face (using an include inside a loop is not a request to make the loop asynchronous), and causes #527, so I plan to revert it in an upcoming version. Just making a note of it here so anyone affected by this bug can look into alternate resolutions.

[carljm]

Reverted in 525abc2 -- re-opening this bug in case anyone wants to propose a better fix. (Perhaps an include should only trigger async-conversion for the if statement if it's enclosed within an async loop? Not sure.)