Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed postinstall-build in favor of npm prepare script #1172

Merged
merged 1 commit into from
Jan 12, 2019
Merged

Removed postinstall-build in favor of npm prepare script #1172

merged 1 commit into from
Jan 12, 2019

Conversation

guilhermehn
Copy link

Summary

Proposed change:

postinstall-build is now deprecated because of npm@4 prepare lifecycle script.

This will break for people using nunjucks as a git dependency with npm < 4. As node 6 end-of-life is coming close, less people will be using npm@3.x. This will help with the third Purpose item:

Also, npm@5 is the actual LTS version, so npm@3 and npm@4 should be considered deprecated.

Closes #1167.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@edevil
Copy link

edevil commented Dec 14, 2018

Any feedback on this?

@fdintino
Copy link
Collaborator

This looks good to me. I'd like to check one additional thing, but then it should be ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

npm warning about postinstall-build deprecation
4 participants