Emit 'load' events on Loader and Environment instances #1196
+140
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1196 +/- ##
==========================================
- Coverage 89.94% 89.81% -0.14%
==========================================
Files 22 22
Lines 2985 2995 +10
==========================================
+ Hits 2685 2690 +5
- Misses 300 305 +5
Continue to review full report at Codecov.
|
chocolateboy
approved these changes
Mar 4, 2019
chocolateboy
reviewed
Mar 4, 2019
|
|
||
| The 'load' event gets emitted whenever a Loader retrieves the source of a | ||
| template. It can be listened to in order to determine template dependencies | ||
| at runtime. The arguments emitted to the callback are: |
chocolateboy
reviewed
Mar 4, 2019
| @@ -59,4 +60,26 @@ class Obj { | |||
| } | |||
| } | |||
|
|
|||
| module.exports = Obj; | |||
| class EmitterObj extends EventEmitter { | |||
There was a problem hiding this comment.
Probably not worth changing now, but other EventEmitters are available, e.g. little-emitter, which is smaller and doesn't require the addition or modification of a superclass:
const EventEmitter = require('little-emitter');
class Environment {
constructor() {
EventEmitter(this); // mix in `emit`, `on` etc.
}
}There was a problem hiding this comment.
I went with the default webpack events shim just because it's so widely used, it was easy, it's well documented, and it only added 1.5K gzipped to the minified builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a 'load' event to
EnvironmentandLoaderinstances, to allow runtime dependency detection.Closes #1153
Checklist
I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.