Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mocha version #1292

Merged
merged 2 commits into from
Jul 9, 2020
Merged

Fix mocha version #1292

merged 2 commits into from
Jul 9, 2020

Conversation

ogonkov
Copy link
Contributor

@ogonkov ogonkov commented Jun 13, 2020

Summary

Proposed change:

Since mocha @ 8.x it's not compatible with now deprecated mocha-phantomjs-core. As temporary solution this PR is fixing mocha version to latest release in 7.x upstream.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@codecov-commenter
Copy link

codecov-commenter commented Jun 13, 2020

Codecov Report

Merging #1292 into master will decrease coverage by 0.04%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1292      +/-   ##
==========================================
- Coverage   89.60%   89.55%   -0.05%     
==========================================
  Files          22       22              
  Lines        3020     3025       +5     
==========================================
+ Hits         2706     2709       +3     
- Misses        314      316       +2     
Impacted Files Coverage Δ
nunjucks/src/node-loaders.js 65.67% <0.00%> (-2.99%) ⬇️
nunjucks/src/filters.js 96.18% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2031bf2...647fc11. Read the comment docs.

@mroderick
Copy link

This PR looks good to me. Is anything holding it back from being merged?

@ogonkov
Copy link
Contributor Author

ogonkov commented Jun 22, 2020

See @fdintino comment #1279 (comment)

I don't know any other maintainer that is active in this repo :(

@fdintino fdintino merged commit 647fc11 into mozilla:master Jul 9, 2020
@ogonkov ogonkov deleted the fix_tests branch July 12, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants