Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CallExtensionAsync parse #1357

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ogonkov
Copy link
Contributor

@ogonkov ogonkov commented Jun 19, 2021

Summary

Proposed change:

Fix parsing of async extensions. It's treated as filter now, and looks like old typo.

Checklist

I've completed the checklist below to ensure I didn't forget anything. This makes reviewing this PR as easy as possible for the maintainers. And it gets this change released as soon as possible.

@ogonkov ogonkov marked this pull request as draft June 19, 2021 14:51
@codecov
Copy link

codecov bot commented Jun 19, 2021

Codecov Report

Merging #1357 (8df0dae) into master (d34fdbf) will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1357      +/-   ##
==========================================
+ Coverage   89.65%   89.82%   +0.16%     
==========================================
  Files          22       22              
  Lines        3046     3046              
==========================================
+ Hits         2731     2736       +5     
+ Misses        315      310       -5     
Impacted Files Coverage Δ
nunjucks/src/transformer.js 98.90% <ø> (ø)
nunjucks/src/compiler.js 96.72% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d34fdbf...8df0dae. Read the comment docs.

@ogonkov ogonkov marked this pull request as ready for review June 19, 2021 16:42
@ogonkov
Copy link
Contributor Author

ogonkov commented Jun 20, 2021

Very strange, this tests runs locally without any problems.

@brettdewoody
Copy link

brettdewoody commented Jul 15, 2021

The error seems to be a missing module at ../src/precompile. This looks like an incorrect relative path in bin/compile.

I believe the import should be ../nunjucks/src/precompile. And there's another import in that same file (../src/environment) which should be ../nunjucks/src/environment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants