make the "default" filter match the behavior of Jinja for falsy values

[chrisdanford]

Falsy values shouldn't be replaced by the default value unless the optional "bool" parameter is truthy. See http://jinja.pocoo.org/docs/templates/#default.

[jlongster]

I can see the reasoning for this, but it sucks to possibly break people's existing templates. I like that it maps directly to foo || bar, but I realize now it's not meant for that. Also, in nunjucks {{ foo or bar }} works the way it does in JS, so that's what you should be doing if you want it to act that way.

Thanks, this will have to go out in 1.1 (no breaking changes in .0.1 releases) so I'm going to wait to merge this until I make sure 1.0 is stable.

[mattbasta]

We should have a branch for 1.1

[jlongster]

Yep, let's do that. I always hate asking people to change branches in their PRs but only bigger changes need it, like this one. Chris, I just created a 1.1 branch, can you change the target of this PR to it?

[chrisdanford]

I'm probably blind, but I couldn't figure out how to change the target branch on a PR without creating a new one. This seems to indicate that it's not possible isaacs/github#18. I created a new PR.

Thanks James!

[jlongster]

Thanks! I'm pretty sure you can somewhere but I don't have any PRs right now to check... The new UI made PRs so much more confusing than they used to be.