-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add text for adoption of .njk extension #691
Conversation
add text for adoption of .njk extension
Thanks! |
add text for adoption of .njk extension
* 2.x: Bump version to 2.5.0-dev.2. Update version in Changelog, too. Release 2.4.1. Backport not escaping SafeString; it's a bug. Update changelog. Merge pull request #701 from legutierr/master Merge pull request #623 from atian25/filters-escape Throw an error if a block is defined multiple times. Refs #696. Update changelog. Grammar fixes. Merge pull request #691 from dkebler/file-ext Update changelog. Merge branch 't576'
Great, though, we always used just Maybe now would be appropriate time to overlook #475? |
Nothing wrong with continuing to use I still don't like #475 -- I think the recommended extension should remain a matter only for the documentation and the community, not something that has an actual effect on the behavior. Even if it were configurable, I still don't see the benefit -- it makes your includes etc correspond less clearly to the actual template files, why is that a good thing? |
Sure. Just wonder, why was chosen Anyways, it definitely not that important, but just my two cents. It seems strange to have ending
I've replied here #475 (comment) to avoid off-topic. |
It was discussed briefly on the Google group mailing list. I said I didn't care between |
with this small edit it was easier to just start over with your latest commit with multiple edits. of templating.md. Also made all textual lowercase nunjucks to Nunjucks