Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add text for adoption of .njk extension #691

Merged
merged 1 commit into from
Mar 14, 2016
Merged

add text for adoption of .njk extension #691

merged 1 commit into from
Mar 14, 2016

Conversation

dkebler
Copy link
Contributor

@dkebler dkebler commented Mar 3, 2016

with this small edit it was easier to just start over with your latest commit with multiple edits. of templating.md. Also made all textual lowercase nunjucks to Nunjucks

carljm added a commit that referenced this pull request Mar 14, 2016
add text for adoption of .njk extension
@carljm carljm merged commit 9cfac7d into mozilla:master Mar 14, 2016
@carljm
Copy link
Contributor

carljm commented Mar 14, 2016

Thanks!

carljm added a commit that referenced this pull request Mar 14, 2016
add text for adoption of .njk extension
carljm added a commit that referenced this pull request Mar 17, 2016
* 2.x:
  Bump version to 2.5.0-dev.2.
  Update version in Changelog, too.
  Release 2.4.1.
  Backport not escaping SafeString; it's a bug.
  Update changelog.
  Merge pull request #701 from legutierr/master
  Merge pull request #623 from atian25/filters-escape
  Throw an error if a block is defined multiple times. Refs #696.
  Update changelog.
  Grammar fixes.
  Merge pull request #691 from dkebler/file-ext
  Update changelog.
  Merge branch 't576'
@ArmorDarks
Copy link

Great, though, we always used just *.nj for years...

Maybe now would be appropriate time to overlook #475?

@carljm
Copy link
Contributor

carljm commented Apr 27, 2016

Nothing wrong with continuing to use .nj if you prefer it, but I think it's useful to have a documented preference. No matter what we picked, it wouldn't match what someone out there has been using...

I still don't like #475 -- I think the recommended extension should remain a matter only for the documentation and the community, not something that has an actual effect on the behavior. Even if it were configurable, I still don't see the benefit -- it makes your includes etc correspond less clearly to the actual template files, why is that a good thing?

@ArmorDarks
Copy link

Nothing wrong with continuing to use .nj if you prefer it, but I think it's useful to have a documented preference. No matter what we picked, it wouldn't match what someone out there has been using...

Sure. Just wonder, why was chosen .njk? I didn't find any discussion about it. Did I miss something? Just curios.

Anyways, it definitely not that important, but just my two cents. It seems strange to have ending k. It's like to have .jst for JavaScript just because it ends with t.

I still don't like #475 -- I think the recommended extension should remain a matter only for the documentation and the community, not something that has an actual effect on the behavior. Even if it were configurable, I still don't see the benefit -- it makes your includes etc correspond less clearly to the actual template files, why is that a good thing?

I've replied here #475 (comment) to avoid off-topic.

@carljm
Copy link
Contributor

carljm commented Apr 28, 2016

It was discussed briefly on the Google group mailing list. I said I didn't care between nj and njk, and would leave it up to whoever submitted a PR to paint the bikeshed. I have a slight preference toward nj myself, but I don't really care.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants