Remove string truncation for error output. #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any chance you could add a test for this change? |
|
@carljm: test added. |
|
Great work, thank you! I'll merge as soon as AppVeyor says all is green... |
carljm
added a commit
that referenced
this pull request
Mar 17, 2016
Remove string truncation for error output.
carljm
added a commit
that referenced
this pull request
Mar 17, 2016
Remove string truncation for error output.
carljm
added a commit
that referenced
this pull request
Mar 17, 2016
* 2.x: Fix changelog. Update changelog. Merge pull request #702 from dbendy/remove-name-truncation opic branch.
|
@carljm: thanks for merging this. Approximately when should I expect a new Nunjucks 2.0 tag with it? |
|
Unfortunately I released v2.4.1 yesterday just seconds before you submitted your PR, so I'll probably wait a bit for a few more fixes to accumulate before I release 2.4.2 or 2.5. |
|
(I would guess at least 2-3 weeks, possibly longer.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to see the full name of a missing function when an error is thrown. In this PR, I removed the string truncation that is occurring for error outputs.