Support ECMAScript 2015 Map and Set in length filter #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They both expose a 'size' property: http://www.ecma-international.org/ecma-262/6.0/#sec-get-map.prototype.size http://www.ecma-international.org/ecma-262/6.0/#sec-get-set.prototype.size Use that instead of the 'length' property. Also added two tests that only run if the respective globals are set.
|
It isn't very clear to me to what extent ES2015 is embraced by Nunjucks, but I made the pull request anyway since they seemed roughly equivalent to Python dicts and sets. |
|
This looks good to me! I don't think nunjucks currently has much ES2015 support, but that's no reason not to start improving it. Thanks for the PR! I'm on vacation for the next two weeks, but I'll merge it when I get back |
carljm
added a commit
that referenced
this pull request
Apr 5, 2016
Support ECMAScript 2015 Map and Set in length filter
carljm
added a commit
that referenced
this pull request
Apr 15, 2016
* 2.x: Bump version for 2.5.0 dev. Bump version for 2.4.2 release. Fix use of 'in' operator with strings. Fixes #714. Make a note that setting web:async:true in your config requires use of async render API. Fix docs build. Docs : Update translations in french Merge pull request #721 from jbmoelker/api-docs-prefix-environment Merge branch 'ughitsaaron-docs-add-gulp' Merge branch 'jbmoelker-patch-1' Update changelog. Merge pull request #705 from ricordisamoa/mapset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They both expose a 'size' property:
http://www.ecma-international.org/ecma-262/6.0/#sec-get-map.prototype.size
http://www.ecma-international.org/ecma-262/6.0/#sec-get-set.prototype.size
Use that instead of the 'length' property.
Also added two tests that only run if the respective globals are set.