This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
rename project (fixes #23) — DON'T MERGE! #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what it'd look like to rename the project to offline-github-pages while calling the command-line tool oghp. This is a complete fix for #23 (the only test failure is due to offline-github-pages not yet existing in npm), but I've labeled it WIP (and marked it
DON'T MERGE!) because I'm still not sure that we should do it.I'll decide by tomorrow, but at the moment, after looking at this, I'm leaning against changing the name, since it's easier to remember the name of the command-line tool if it's the same name as the package (and project), and offline-github-pages is long and cumbersome as a name for a command-line tool.