Merge pull request #9629 from wojtekmaj/add-autoprefixer

Implement autoprefixer
mozilla · Apr 8, 2018 · 1a634f9 · 1a634f9
2 parents a7a034d + 69e9fe2
commit 1a634f9
Show file tree

Hide file tree

Showing 7 changed files with 38 additions and 140 deletions.
diff --git a/gulpfile.js b/gulpfile.js
@@ -18,9 +18,11 @@
 
 'use strict';
 
+var autoprefixer = require('autoprefixer');
 var fancylog = require('fancy-log');
 var fs = require('fs');
 var gulp = require('gulp');
+var postcss = require('gulp-postcss');
 var rename = require('gulp-rename');
 var replace = require('gulp-replace');
 var transform = require('gulp-transform');
@@ -69,6 +71,20 @@ var builder = require('./external/builder/builder.js');
 var CONFIG_FILE = 'pdfjs.config';
 var config = JSON.parse(fs.readFileSync(CONFIG_FILE).toString());
 
+// Default Autoprefixer config used for generic, components, minifed-pre
+var AUTOPREFIXER_CONFIG = {
+  browsers: [
+    'last 2 versions',
+    'Chrome >= 49', // Last supported on Windows XP
+    'Firefox >= 52', // Last supported on Windows XP
+    'Firefox ESR',
+    'IE >= 11',
+    'Safari >= 8',
+    '> 0.5%',
+    'not dead',
+  ],
+};
+
 var DEFINES = {
   PRODUCTION: true,
   // The main build targets:
@@ -577,6 +593,7 @@ gulp.task('generic', ['buildnumber', 'locale'], function () {
     preprocessHTML('web/viewer.html', defines)
         .pipe(gulp.dest(GENERIC_DIR + 'web')),
     preprocessCSS('web/viewer.css', 'generic', defines, true)
+        .pipe(postcss([autoprefixer(AUTOPREFIXER_CONFIG)]))
         .pipe(gulp.dest(GENERIC_DIR + 'web')),
 
     gulp.src('web/compressed.tracemonkey-pldi-09.pdf')
@@ -602,6 +619,7 @@ gulp.task('components', ['buildnumber'], function () {
     createComponentsBundle(defines).pipe(gulp.dest(COMPONENTS_DIR)),
     gulp.src(COMPONENTS_IMAGES).pipe(gulp.dest(COMPONENTS_DIR + 'images')),
     preprocessCSS('web/pdf_viewer.css', 'components', defines, true)
+        .pipe(postcss([autoprefixer(AUTOPREFIXER_CONFIG)]))
         .pipe(gulp.dest(COMPONENTS_DIR)),
   ]);
 });
@@ -629,6 +647,7 @@ gulp.task('minified-pre', ['buildnumber', 'locale'], function () {
     preprocessHTML('web/viewer.html', defines)
         .pipe(gulp.dest(MINIFIED_DIR + 'web')),
     preprocessCSS('web/viewer.css', 'minified', defines, true)
+        .pipe(postcss([autoprefixer(AUTOPREFIXER_CONFIG)]))
         .pipe(gulp.dest(MINIFIED_DIR + 'web')),
 
     gulp.src('web/compressed.tracemonkey-pldi-09.pdf')
@@ -719,6 +738,9 @@ gulp.task('mozcentral-pre', ['buildnumber', 'locale'], function () {
     preprocessHTML('web/viewer.html', defines)
         .pipe(gulp.dest(MOZCENTRAL_CONTENT_DIR + 'web')),
     preprocessCSS('web/viewer.css', 'mozcentral', defines, true)
+        .pipe(postcss([
+            autoprefixer({ browsers: ['last 1 firefox versions'], })
+        ]))
         .pipe(gulp.dest(MOZCENTRAL_CONTENT_DIR + 'web')),
 
     gulp.src(FIREFOX_EXTENSION_DIR + 'locale/en-US/*.properties')
@@ -766,6 +788,7 @@ gulp.task('chromium-pre', ['buildnumber', 'locale'], function () {
     preprocessHTML('web/viewer.html', defines)
         .pipe(gulp.dest(CHROME_BUILD_CONTENT_DIR + 'web')),
     preprocessCSS('web/viewer.css', 'chrome', defines, true)
+        .pipe(postcss([autoprefixer({ browsers: ['chrome >= 49'], })]))
         .pipe(gulp.dest(CHROME_BUILD_CONTENT_DIR + 'web')),
 
     gulp.src('LICENSE').pipe(gulp.dest(CHROME_BUILD_DIR)),

diff --git a/package.json b/package.json
@@ -3,6 +3,7 @@
   "version": "2.0.0",
   "devDependencies": {
     "acorn": "^5.5.3",
+    "autoprefixer": "^8.2.0",
     "babel-core": "^6.26.0",
     "babel-loader": "^7.1.4",
     "babel-plugin-transform-es2015-modules-commonjs": "^6.26.0",
@@ -14,6 +15,7 @@
     "eslint-plugin-no-unsanitized": "^3.0.0",
     "fancy-log": "^1.3.2",
     "gulp": "^3.9.1",
+    "gulp-postcss": "^7.0.1",
     "gulp-rename": "^1.2.2",
     "gulp-replace": "^0.6.1",
     "gulp-transform": "^3.0.5",

diff --git a/test/annotation_layer_builder_overrides.css b/test/annotation_layer_builder_overrides.css
@@ -19,6 +19,11 @@
   position: absolute;
 }
 
+.annotationLayer .buttonWidgetAnnotation.checkBox input,
+.annotationLayer .buttonWidgetAnnotation.radioButton input {
+  -webkit-appearance: none;
+}
+
 .annotationLayer .linkAnnotation > a,
 .annotationLayer .buttonWidgetAnnotation.pushButton > a {
   opacity: 0.2;

diff --git a/web/annotation_layer_builder.css b/web/annotation_layer_builder.css
@@ -144,9 +144,6 @@
 
 .annotationLayer .buttonWidgetAnnotation.checkBox input,
 .annotationLayer .buttonWidgetAnnotation.radioButton input {
-  -webkit-appearance: none;
-  -moz-appearance: none;
-  -ms-appearance: none;
   appearance: none;
   padding: 0;
 }

diff --git a/web/pdf_viewer.css b/web/pdf_viewer.css
@@ -65,19 +65,8 @@
   background: url('images/loading-icon.gif') center no-repeat;
 }
 
-.pdfPresentationMode:-webkit-full-screen .pdfViewer .page {
-  margin-bottom: 100%;
-  border: 0;
-}
-
-.pdfPresentationMode:-moz-full-screen .pdfViewer .page {
-  margin-bottom: 100%;
-  border: 0;
-}
-
 .pdfPresentationMode:-ms-fullscreen .pdfViewer .page {
   margin-bottom: 100% !important;
-  border: 0;
 }
 
 .pdfPresentationMode:fullscreen .pdfViewer .page {

diff --git a/web/text_layer_builder.css b/web/text_layer_builder.css
@@ -29,10 +29,6 @@
   position: absolute;
   white-space: pre;
   cursor: text;
-  -webkit-transform-origin: 0% 0%;
-  -moz-transform-origin: 0% 0%;
-  -o-transform-origin: 0% 0%;
-  -ms-transform-origin: 0% 0%;
   transform-origin: 0% 0%;
 }
 
@@ -61,7 +57,6 @@
 }
 
 .textLayer ::selection { background: rgb(0,0,255); }
-.textLayer ::-moz-selection { background: rgb(0,0,255); }
 
 .textLayer .endOfContent {
   display: block;
@@ -72,9 +67,7 @@
   bottom: 0px;
   z-index: -1;
   cursor: default;
-  -webkit-user-select: none;
-  -ms-user-select: none;
-  -moz-user-select: none;
+  user-select: none;
 }
 
 .textLayer .endOfContent.active {