Merge pull request #15031 from Snuffleupagus/prefer-modern-dom-apis

Enable the `unicorn/prefer-modern-dom-apis` ESLint plugin rule
mozilla · Jun 12, 2022 · 1a6ae5f · 1a6ae5f
2 parents 0e1e265 + 4d39898
commit 1a6ae5f
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -55,6 +55,7 @@
     "unicorn/prefer-date-now": "error",
     "unicorn/prefer-dom-node-append": "error",
     "unicorn/prefer-dom-node-remove": "error",
+    "unicorn/prefer-modern-dom-apis": "error",
     "unicorn/prefer-string-starts-ends-with": "error",
 
     // Possible errors

diff --git a/extensions/chromium/contentscript.js b/extensions/chromium/contentscript.js
@@ -133,7 +133,7 @@ function updateEmbedElement(elem) {
   elem.type = "text/html";
   elem.src = getEmbeddedViewerURL(elem.src);
   if (parentNode) {
-    parentNode.insertBefore(elem, nextSibling);
+    nextSibling.before(elem);
   }
 }
 

diff --git a/src/display/annotation_layer.js b/src/display/annotation_layer.js
@@ -2559,9 +2559,9 @@ class AnnotationLayer {
       if (!firstChild) {
         element.append(canvas);
       } else if (firstChild.nodeName === "CANVAS") {
-        element.replaceChild(canvas, firstChild);
+        firstChild.replaceWith(canvas);
       } else {
-        element.insertBefore(canvas, firstChild);
+        firstChild.before(canvas);
       }
     }
     annotationCanvasMap.clear();

diff --git a/web/pdf_page_view.js b/web/pdf_page_view.js
@@ -627,7 +627,7 @@ class PDFPageView {
 
     if (lastDivBeforeTextDiv) {
       // The annotation layer needs to stay on top.
-      div.insertBefore(canvasWrapper, lastDivBeforeTextDiv);
+      lastDivBeforeTextDiv.before(canvasWrapper);
     } else {
       div.append(canvasWrapper);
     }
@@ -640,7 +640,7 @@ class PDFPageView {
       textLayerDiv.style.height = canvasWrapper.style.height;
       if (lastDivBeforeTextDiv) {
         // The annotation layer needs to stay on top.
-        div.insertBefore(textLayerDiv, lastDivBeforeTextDiv);
+        lastDivBeforeTextDiv.before(textLayerDiv);
       } else {
         div.append(textLayerDiv);
       }