Fix error reading concatenated pdfs

mozilla · Apr 4, 2015 · 1b153ad · 1b153ad
1 parent 32cc021
commit 1b153ad
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 6 deletions.
diff --git a/src/core/obj.js b/src/core/obj.js
@@ -1051,12 +1051,13 @@ var XRef = (function XRefClosure() {
           trailers.push(position);
           position += skipUntil(buffer, position, startxrefBytes);
         } else if ((m = /^(\d+)\s+(\d+)\s+obj\b/.exec(token))) {
-          this.entries[m[1]] = {
-            offset: position,
-            gen: m[2] | 0,
-            uncompressed: true
-          };
-
+          if (typeof this.entries[m[1]] === 'undefined') {
+            this.entries[m[1]] = {
+              offset: position,
+              gen: m[2] | 0,
+              uncompressed: true
+            };
+          }
           var contentLength = skipUntil(buffer, position, endobjBytes) + 7;
           var content = buffer.subarray(position, position + contentLength);
 

diff --git a/test/pdfs/.gitignore b/test/pdfs/.gitignore
@@ -122,3 +122,4 @@
 !issue5481.pdf
 !issue5567.pdf
 !issue5701.pdf
+!issue5909.pdf
diff --git a/test/pdfs/issue5909.pdf b/test/pdfs/issue5909.pdf
diff --git a/test/test_manifest.json b/test/test_manifest.json
@@ -2080,5 +2080,11 @@
        "md5": "d5b37f8bf1b3aafa1b4fcf19ebdc7c74",
        "rounds": 1,
        "type": "eq"
+    },
+    {  "id": "issue5909",
+       "file": "pdfs/issue5909.pdf",
+       "md5": "65c169b6f540b27ac0ff2738a80d1e14",
+       "rounds": 1,
+       "type": "eq"
     }
 ]