Merge pull request #17095 from timvandermeij/protocol-timeout

Fix the protocol timeout configuration for Puppeteer
mozilla · Oct 9, 2023 · b4cd8ad · b4cd8ad
2 parents d64f223 + ede65e1
commit b4cd8ad
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/test/test.mjs b/test/test.mjs
@@ -907,6 +907,11 @@ async function startBrowser(browserName, startUrl = "") {
     headless: false,
     defaultViewport: null,
     ignoreDefaultArgs: ["--disable-extensions"],
+    // The timeout for individual protocol (CDP) calls should always be lower
+    // than the Jasmine timeout. This way protocol errors are always raised in
+    // the context of the tests that actually triggered them and don't leak
+    // through to other tests (causing unrelated failures or tracebacks).
+    protocolTimeout: /* jasmine.DEFAULT_TIMEOUT_INTERVAL = */ 30000 - 1000,
   };
 
   if (!tempDir) {