Skip to content

Commit

Permalink
Merge pull request #15776 from Snuffleupagus/rm-createDownloadManager…
Browse files Browse the repository at this point in the history
…-options

Remove the unused `DefaultExternalServices.createDownloadManager` options (PR 12191 follow-up)
  • Loading branch information
Snuffleupagus authored Dec 7, 2022
2 parents 0ca92bf + 9369adb commit c639063
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion web/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ class DefaultExternalServices {

static reportTelemetry(data) {}

static createDownloadManager(options) {
static createDownloadManager() {
throw new Error("Not implemented: createDownloadManager");
}

Expand Down
2 changes: 1 addition & 1 deletion web/chromecom.js
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ class ChromeExternalServices extends DefaultExternalServices {
);
}

static createDownloadManager(options) {
static createDownloadManager() {
return new DownloadManager();
}

Expand Down
2 changes: 1 addition & 1 deletion web/firefoxcom.js
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ class FirefoxExternalServices extends DefaultExternalServices {
FirefoxCom.request("reportTelemetry", JSON.stringify(data));
}

static createDownloadManager(options) {
static createDownloadManager() {
return new DownloadManager();
}

Expand Down
2 changes: 1 addition & 1 deletion web/genericcom.js
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ class GenericPreferences extends BasePreferences {
}

class GenericExternalServices extends DefaultExternalServices {
static createDownloadManager(options) {
static createDownloadManager() {
return new DownloadManager();
}

Expand Down

0 comments on commit c639063

Please sign in to comment.