Merge pull request #18571 from timvandermeij/linting

Enable the `unicorn/{prefer-includes,throw-new-error}` linting rules

.eslintrc

@@ -45,7 +45,6 @@
  "ignore": ["display", "pdfjs", "pdfjs-lib", "pdfjs-web", "web", "fluent-bundle", "fluent-dom"],
  }],
  "mozilla/avoid-removeChild": "error",
- "mozilla/use-includes-instead-of-indexOf": "error",
  "no-unsanitized/method": "error",
  "no-unsanitized/property": "error",
  "sort-exports/sort-exports": ["error", {
@@ -70,6 +69,7 @@
  "unicorn/prefer-date-now": "error",
  "unicorn/prefer-dom-node-append": "error",
  "unicorn/prefer-dom-node-remove": "error",
+ "unicorn/prefer-includes": "error",
  "unicorn/prefer-logical-operator-over-ternary": "error",
  "unicorn/prefer-modern-dom-apis": "error",
  "unicorn/prefer-modern-math-apis": "error",
@@ -79,6 +79,7 @@
  "unicorn/prefer-string-replace-all": "error",
  "unicorn/prefer-string-starts-ends-with": "error",
  "unicorn/prefer-ternary": ["error", "only-single-line"],
+ "unicorn/throw-new-error": "error",
 
  // Possible errors
  "for-direction": "error",

test/driver.js

@@ -1075,7 +1075,7 @@ class Driver {
  this.output.textContent += message;
  }
 
- if (message.lastIndexOf("\n") >= 0 && !this.disableScrolling.checked) {
+ if (message.includes("\n") && !this.disableScrolling.checked) {
  // Scroll to the bottom of the page
  this.output.scrollTop = this.output.scrollHeight;
  }