fix: use parentNode.insertBefore() for adding the node

mozilla · Jun 29, 2023 · dce076e · dce076e
1 parent 7818da0
commit dce076e
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/extensions/chromium/contentscript.js b/extensions/chromium/contentscript.js
@@ -133,10 +133,11 @@ function updateEmbedElement(elem) {
   elem.type = "text/html";
   elem.src = getEmbeddedViewerURL(elem.src);
 
-  if (nextSibling) {
-    nextSibling.before(elem);
-  } else if (parentNode) {
-    parentNode.append(elem);
+  if (parentNode) {
+    // Suppress linter warning: insertBefore is preferable to
+    // nextSibling.before(elem) because nextSibling may be null.
+    // eslint-disable-next-line unicorn/prefer-modern-dom-apis
+    parentNode.insertBefore(elem, nextSibling);
   }
 }