Skip to content

Commit

Permalink
Re-factor the npm test command, used by Travis, to avoid running th…
Browse files Browse the repository at this point in the history
…e 'default_preferences' tasks concurrently (issue 10732)

*Please note:* This patch does *not* prevent the 'default_preferences' task from running more than once during `npm test`, but it does ensure that the tasks won't run *concurrently* by running the relevant tests in *series*.

While it would obviously still make sense to re-factor the gulpfile to account for changes in `gulp` version 4, by at least tweaking the `npm test` command the intermittent failures on Travis should at least go away.
  • Loading branch information
Snuffleupagus committed Dec 18, 2019
1 parent 7ceb394 commit f406263
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions gulpfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -1502,3 +1502,6 @@ gulp.task('externaltest', function (done) {
{ stdio: 'inherit', });
done();
});

gulp.task('npm-test', gulp.series(gulp.parallel('lint', 'externaltest'),
'unittestcli'));
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"yargs": "^11.1.1"
},
"scripts": {
"test": "env SKIP_BABEL=true gulp lint unittestcli externaltest"
"test": "env SKIP_BABEL=true gulp npm-test"
},
"repository": {
"type": "git",
Expand Down

0 comments on commit f406263

Please sign in to comment.