Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible typo/error in the src/scripting_api/field.js file #12684

Closed
Snuffleupagus opened this issue Dec 2, 2020 · 1 comment
Closed

Possible typo/error in the src/scripting_api/field.js file #12684

Snuffleupagus opened this issue Dec 2, 2020 · 1 comment
Assignees

Comments

@Snuffleupagus
Copy link
Collaborator

The following code looks really strange, since I cannot imagine that using an Array together with a bitwise OR operator (|) makes much sense in general!?
Shouldn't these lines simply use a "normal" OR operator (||) instead?

this._fillColor = data.fillColor | ["T"];
this._strokeColor = data.strokeColor | ["G", 0];
this._textColor = data.textColor | ["G", 0];

/cc @calixteman

@calixteman calixteman self-assigned this Dec 2, 2020
@calixteman
Copy link
Contributor

my bad... you're right it should be a ||.

calixteman added a commit to calixteman/pdf.js that referenced this issue Dec 2, 2020
calixteman added a commit that referenced this issue Dec 3, 2020
Fix issue #12684: replace bitwise ORs by ORs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants