Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken CSS Build in pdfjs-dist (v3.11.174) #17044

Closed
andrewlistopadov opened this issue Sep 28, 2023 · 3 comments · Fixed by #17053
Closed

Broken CSS Build in pdfjs-dist (v3.11.174) #17044

andrewlistopadov opened this issue Sep 28, 2023 · 3 comments · Fixed by #17053
Assignees
Labels
editor release-blocker Blocker for the upcoming release viewer

Comments

@andrewlistopadov
Copy link

Configuration:

  • PDF.js version: v3.11.174

What went wrong? (add screenshot)
There seems to be new images import in pdfjs-dist/web/pdf_viewer.css

  --alt-text-add-image: url(images/altText_add.svg);
  --alt-text-done-image: url(images/altText_done.svg);

But there are no such files there. Build is failed due to this reason.

pdfjs-dist/web/pdf_viewer.css:835:29: Can't resolve 'images/altText_add.svg' in '.../node_modules/pdfjs-dist/web'
pdfjs-dist/web/pdf_viewer.css:836:30: Can't resolve 'images/altText_done.svg' in '.../node_modules/pdfjs-dist/web'

@yu-nakagawa

This comment was marked as duplicate.

@timvandermeij
Copy link
Contributor

@calixteman This seems related to the new alt text dialog; could you perhaps take a look at this?

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Oct 1, 2023

This should be pretty trivial to fix, simply by extending this list to include the new images, however after seeing #17044 (comment) above (which comes across as rude and entitled) I just didn't feel like spending my spare time writing a patch for this.

calixteman added a commit to calixteman/pdf.js that referenced this issue Oct 1, 2023
@calixteman calixteman linked a pull request Oct 1, 2023 that will close this issue
timvandermeij added a commit that referenced this issue Oct 1, 2023
Add alt-text svg images to the dist (issue #17044)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor release-blocker Blocker for the upcoming release viewer
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants