You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In #17260 we found that this integration test consistently failed, but figured it couldn't really be related to that PR, so I made #17261 to show that this integration test is already broken on master. I have bisected it and found that this regressed in #17243 in which sadly no integration tests were run, so that's probably why this went by unnoticed. If I revert that commit the test works again.
@calixteman Could you perhaps check why this test fails with 334f0eb applied? (I already had a quick look, but it wasn't immediately obvious to me why, and I'm sure you know the details of that patch much better than I do.)
Traceback:
Failures:
1) FreeText Editor FreeText must check that text change can be undone/redone
Message:
�[31m ProtocolError: Waiting for selector `#pdfjs_internal_editor_9 .overlay.enabled` failed: Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.�[0m
Stack:
at <instance_members_initializer> (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:92:14)
at new Callback (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:96:16)
at CallbackRegistry.create (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:29:26)
at Connection._rawSend (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/Connection.js:88:26)
at CdpCDPSession.send (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/CDPSession.js:75:33)
at #evaluate (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:208:50)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async ExecutionContext.evaluateHandle (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:175:16)
at async IsolatedWorld.evaluateHandle (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/IsolatedWorld.js:120:16)
at async CdpJSHandle.evaluateHandle (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/api/JSHandle.js:163:20)
The text was updated successfully, but these errors were encountered:
In #17260 we found that this integration test consistently failed, but figured it couldn't really be related to that PR, so I made #17261 to show that this integration test is already broken on master. I have bisected it and found that this regressed in #17243 in which sadly no integration tests were run, so that's probably why this went by unnoticed. If I revert that commit the test works again.
@calixteman Could you perhaps check why this test fails with 334f0eb applied? (I already had a quick look, but it wasn't immediately obvious to me why, and I'm sure you know the details of that patch much better than I do.)
Traceback:
The text was updated successfully, but these errors were encountered: