Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test "FreeText Editor FreeText must check that text change can be undone/redone" #17262

Closed
timvandermeij opened this issue Nov 11, 2023 · 2 comments · Fixed by #17264
Assignees
Labels

Comments

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 11, 2023

In #17260 we found that this integration test consistently failed, but figured it couldn't really be related to that PR, so I made #17261 to show that this integration test is already broken on master. I have bisected it and found that this regressed in #17243 in which sadly no integration tests were run, so that's probably why this went by unnoticed. If I revert that commit the test works again.

@calixteman Could you perhaps check why this test fails with 334f0eb applied? (I already had a quick look, but it wasn't immediately obvious to me why, and I'm sure you know the details of that patch much better than I do.)

Traceback:

Failures:
1) FreeText Editor FreeText must check that text change can be undone/redone
  Message:
�[31m    ProtocolError: Waiting for selector `#pdfjs_internal_editor_9 .overlay.enabled` failed: Runtime.callFunctionOn timed out. Increase the 'protocolTimeout' setting in launch/connect calls for a higher timeout if needed.�[0m
  Stack:
        at <instance_members_initializer> (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:92:14)
        at new Callback (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:96:16)
        at CallbackRegistry.create (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/common/CallbackRegistry.js:29:26)
        at Connection._rawSend (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/Connection.js:88:26)
        at CdpCDPSession.send (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/CDPSession.js:75:33)
        at #evaluate (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:208:50)
        at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
        at async ExecutionContext.evaluateHandle (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/ExecutionContext.js:175:16)
        at async IsolatedWorld.evaluateHandle (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/cdp/IsolatedWorld.js:120:16)
        at async CdpJSHandle.evaluateHandle (file:///C:/pdfjs/botio-files-pdfjs/private/9480a813b92e60b/node_modules/puppeteer-core/lib/esm/puppeteer/api/JSHandle.js:163:20)
@calixteman
Copy link
Contributor

I thought I ran them... but obviously I forgot, sorry about that.
I'm fixing.

@timvandermeij
Copy link
Contributor Author

No worries; that can happen. Thank you for fixing this so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants