[Editor] Add a toolbar to selected editors with a button to delete it (bug 1863763)

[calixteman]

No description provided.

[calixteman]

For the moment the aria-label and maybe the tooltip are missing but the strings should be come later.

[Snuffleupagus]

Leaving a few initial, very quick, observations.

Naming things is hard, but I feel like calling this bin throughout the code is confusing since that mostly describes the content of the icon (which may change at some point).
It would rather seems much more appropriate to describe the functionality, and thus call this e.g. delete (or remove) throughout all the code and in the filename.

[calixteman]

/botio-linux preview

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5e98ebedcd186e0/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/5e98ebedcd186e0/output.txt

Total script time: 1.42 mins

Published

• Viewer: http://54.241.84.105:8877/5e98ebedcd186e0/web/viewer.html
• Viewer (legacy): http://54.241.84.105:8877/5e98ebedcd186e0/legacy/web/viewer.html

[Snuffleupagus]

After playing with this a bit, I've got two observations/questions:

• If you select multiple editors and then click on the new delete-button only that specific editor is deleted, which while reasonable behaviour in itself may possibly be confusing to users.
  Thus I wonder if we need some way to visually notify the user that only one editor will be removed, or if this is implicitly understood because there's multiple delete-buttons visible in this case (i.e. one for each selected editor)?

  (Compare with the situation where you select multiple editors and then press the Delete key, where all selected editors are being removed.)

• I've not looked in detail at the design-spec, so it's possible that you've simply implemented what the specification says.

  Would it make sense to give the editToolbar-element itself a little bit of padding (e.g. 1px all around), since in the focus-visible-state the button-outline and the toolbar-border kind of "blends" together now?
  
  
  

[calixteman]

After playing with this a bit, I've got two observations/questions:

* If you select _multiple_ editors and then click on the new delete-button only that specific editor is deleted, which while reasonable behaviour in itself _may_ possibly be confusing to users.
  Thus I wonder if we need some way to visually notify the user that only _one_ editor will be removed, or if this is implicitly understood because there's multiple delete-buttons visible in this case (i.e. one for each selected editor)?
  (Compare with the situation where you select multiple editors and then press the Delete key, where _all selected_ editors are being removed.)

If the user has selected several editors and then click on the delete button I think it makes sense to delete all of them.

* _I've not looked in detail at the design-spec, so it's possible that you've simply implemented what the specification says._
  Would it make sense to give the editToolbar-element itself _a little bit_ of padding (e.g. `1px` all around), since in the `focus-visible`-state the button-outline and the toolbar-border kind of "blends" together now?

Yes, the border line has been recently added to the specs because it helps to have a contrast between the toolbar and a clear background.
The css :has has landed few weeks ago in nightly, so it's time to use it in removing the border when the a button has a focus-outline.

[Snuffleupagus]

For the moment the aria-label and maybe the tooltip are missing but the strings should be come later.

Should we wait for the l10n-strings to be provided first, or did you intend for this PR to land as-is (with a later follow-up patch)?

---

r=me, since this seems to work as it should; thank you!

[calixteman]

I hope we'll have the strings next week but it's worth having asap in nightly in order to be tested.
So I'll do a follow-up patch once I've them.