You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To avoid useless class constructors we utilize the ESLint no-useless-constructor rule, which works well in most cases.
The exception is when a constructor includes pre-processor statements that make it conditionally empty, note e.g. how the following source code:
To avoid useless
class
constructors we utilize the ESLintno-useless-constructor
rule, which works well in most cases.The exception is when a constructor includes pre-processor statements that make it conditionally empty, note e.g. how the following source code:
pdf.js/src/display/editor/tools.js
Lines 61 to 67 in b676540
is transformed into (in that case for the
MOZCENTRAL
build):https://searchfox.org/mozilla-central/rev/dbd654fa899a56a6a2e92f325c4608020e80afae/toolkit/components/pdfjs/content/build/pdf.mjs#1829
Hence it seems like a good idea to extend the Babel plugin to remove
class
constructors that become empty during building./cc @nicolo-ribaudo
The text was updated successfully, but these errors were encountered: