-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Babel plugin to remove empty class constructors #18060
Update the Babel plugin to remove empty class constructors #18060
Conversation
a8e9e3e
to
e347999
Compare
f724ae9 changed the build script to use Babel, so this commit updates the file names accordingly
e347999
to
5cdc965
Compare
This only happens when it's safe to do so. The exceptions are: - when the class extends another subclass: removing the constructor would remove the error about the missing super() call - when there are default parameters, that could have side effects - when there are destructured prameters, that could have side effects
5cdc965
to
46626ac
Compare
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/35e361ea1c727c3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c73cb7fa3ebb1b6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/c73cb7fa3ebb1b6/output.txt Total script time: 27.63 mins
Image differences available at: http://54.241.84.105:8877/c73cb7fa3ebb1b6/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/35e361ea1c727c3/output.txt Total script time: 42.58 mins
Image differences available at: http://54.193.163.58:8877/35e361ea1c727c3/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, thank you!
Fixes #18057