Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration test "Highlight Editor Highlight with the keyboard must check that some text has been highlighted" #18276

Closed
timvandermeij opened this issue Jun 18, 2024 · 0 comments · Fixed by #18277
Assignees

Comments

@timvandermeij
Copy link
Contributor

In PR #18273 an AFAIK new intermittent showed up. The traceback is visible in the logs from the Linux bot at http://54.241.84.105:8877/1488059b7a5d2f4/output.txt:

1) Highlight Editor Highlight with the keyboard must check that some text has been highlighted
  Message:
�[31m    In chrome: Expected false to be true.�[0m
  Stack:
        at <Jasmine>
        at file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/1488059b7a5d2f4/test/integration/highlight_editor_spec.mjs:712:14
        at async Promise.all (index 1)
        at async UserContext.<anonymous> (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/1488059b7a5d2f4/test/integration/highlight_editor_spec.mjs:677:7)
  Message:
�[31m    In chrome: Expected false to be true.�[0m
  Stack:
        at <Jasmine>
        at file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/1488059b7a5d2f4/test/integration/highlight_editor_spec.mjs:715:14
        at async Promise.all (index 1)
        at async UserContext.<anonymous> (file:///home/ubuntu/pdfjs/botio-files-pdfjs/private/1488059b7a5d2f4/test/integration/highlight_editor_spec.mjs:677:7)

We're doing an evaluation there, but we are probably forgetting to wait for whatever we're evaluating there to occur (that was at least the case in previous similar cases).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants