Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a helper function for handling locally cached image data (PR 18269 follow-up) #18273

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

@Snuffleupagus Snuffleupagus commented Jun 18, 2024

This avoids having to duplicate the same exact code multiple times.

…9 follow-up)

This avoids having to duplicate the same exact code multiple times.
@Snuffleupagus Snuffleupagus force-pushed the addLocallyCachedImageOps branch from 992e630 to 604e897 Compare June 18, 2024 15:21
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1488059b7a5d2f4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e455565ab95bab4/output.txt

Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests. Thank you for deduplicating this!

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/1488059b7a5d2f4/output.txt

Total script time: 28.79 mins

  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/1488059b7a5d2f4/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/e455565ab95bab4/output.txt

Total script time: 43.18 mins

  • Unit tests: FAILED
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 5
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/e455565ab95bab4/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit 7013258 into mozilla:master Jun 18, 2024
9 checks passed
@Snuffleupagus Snuffleupagus deleted the addLocallyCachedImageOps branch June 18, 2024 16:11
@timvandermeij
Copy link
Contributor

timvandermeij commented Jun 18, 2024

I have created #18276 for the new intermittently failing integration test. It's not related to this PR, but I don't recall having seen this particular one before so I'm just creating issues for every single one I find in the hope that soon we'll get rid of all of them :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants