-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a helper function for handling locally cached image data (PR 18269 follow-up) #18273
Add a helper function for handling locally cached image data (PR 18269 follow-up) #18273
Conversation
…9 follow-up) This avoids having to duplicate the same exact code multiple times.
992e630
to
604e897
Compare
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1488059b7a5d2f4/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/e455565ab95bab4/output.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with passing tests. Thank you for deduplicating this!
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1488059b7a5d2f4/output.txt Total script time: 28.79 mins
Image differences available at: http://54.241.84.105:8877/1488059b7a5d2f4/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e455565ab95bab4/output.txt Total script time: 43.18 mins
Image differences available at: http://54.193.163.58:8877/e455565ab95bab4/reftest-analyzer.html#web=eq.log |
I have created #18276 for the new intermittently failing integration test. It's not related to this PR, but I don't recall having seen this particular one before so I'm just creating issues for every single one I find in the hope that soon we'll get rid of all of them :-) |
This avoids having to duplicate the same exact code multiple times.