-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dumpio: true
logs about translateMutations
#18279
Labels
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In PR #18260 we enabled
dumpio: true
for Puppeteer. This option forwards the browser logs to Node's log stream so that we can see any warnings/errors that are logged in e.g. the web console. This surfaced a few interesting issues that we should fix before we enable that further due to the spammy nature of said logs.This issue tracks the following often repeated log from http://54.193.163.58:8877/32bb151d23ef0ea/output.txt:
This is most likely Fluent code being interrupted, and it seems to show up now that we actually close the viewer correctly since PR #18271. Interestingly this mostly (but not exclusively as proven by http://54.241.84.105:8877/c9f8c7617ecd080/output.txt) shows up on the Windows bot. Did this perhaps surface a bug in the viewer's cleanup logic that we're not stopping Fluent translation correctly?
The text was updated successfully, but these errors were encountered: