Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up before closing the tab in integration tests #18271

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Clean up before closing the tab in integration tests #18271

merged 1 commit into from
Jun 18, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/a8a5189402f9432/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/d5f64d8038c5a50/output.txt

This was linked to issues Jun 18, 2024
Fix dumpio: true logs about #createBundleFallback #18264
Closed
Fix dumpio: true logs about Script terminated by timeout #18265
Closed
@calixteman calixteman removed a link to an issue Jun 18, 2024
Fix dumpio: true logs about #createBundleFallback #18264
Closed
Snuffleupagus
Snuffleupagus requested changes Jun 18, 2024
View reviewed changes
web/app.js Outdated Show resolved Hide resolved
web/app.js Show resolved Hide resolved
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a8a5189402f9432/output.txt

Total script time: 0.19 mins

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/d5f64d8038c5a50/output.txt

Total script time: 0.44 mins

Snuffleupagus
Snuffleupagus approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing integrationtest; thank you!

@Snuffleupagus
Copy link
Collaborator

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a3ae6a2495de910/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/12805fc0adca093/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/a3ae6a2495de910/output.txt

Total script time: 7.88 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/12805fc0adca093/output.txt

Total script time: 19.00 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 4c04158 into mozilla:master Jun 18, 2024
7 checks passed
@calixteman calixteman deleted the clean_before_closing branch June 18, 2024 14:56
@timvandermeij
Copy link
Contributor

I have also tested this one locally with dumpio: true and can confirm that all tracebacks are gone. Nice find!

This was referenced Jun 18, 2024
Open
Closed
@ZeroXClem ZeroXClem mentioned this pull request Aug 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix dumpio: true logs about Script terminated by timeout
4 participants
@calixteman @moz-tools-bot @Snuffleupagus @timvandermeij