Download button ignores Content-Disposition/filename header

[fwenzel]

Look at a PDF file served at the URL "view.aspx" with the following response header:

Content-Disposition:filename=myfile.pdf

Now compare:

• CMD/Ctrl+S -- it will open a file download dialog stating "myfile.pdf" as the target filename.
• clicking the "download" button in pdf.js -- it will open a download dialog stating "view.aspx" as the filename.

Evidently, the download button ignores the content-disposition header, while Firefox's "download page" functionality does not.

(sorry I would give you a live example but this is a utility bill behind login)

[erikw]

Yes this is a major problem, all my downloaded PDF files have the wrong name now! This should be fixed sooner than later.

[waddlesplash]

I'm looking into it.

[yurydelendik]

@waddlesplash , you can look into getting Content-Disposition header somewhere at https://github.com/mozilla/pdf.js/blob/master/extensions/firefox/components/PdfStreamConverter.js#L582 (similar to

pdf.js/extensions/firefox/components/PdfStreamConverter.js

Line 551 in 8300349

try {

) using nsIHTTPChannel.getResponseHeader() method.

[yurydelendik]

there is also contentDispositionFilename (http://mxr.mozilla.org/mozilla-central/source/netwerk/base/public/nsIChannel.idl#294)

[waddlesplash]

I'm having trouble using the following code:

const Cu = Components.utils;
Cu.import('resource://gre/modules/Services.jsm');

In the web console:

The Components object is deprecated. It will soon be removed.
TypeError: Cu is undefined

[waddlesplash]

(from viewer.js)

[brendandahl]

viewer.js runs with content permissions. You need to be in chrome code to use Cu. The chrome privileged code lives in https://github.com/mozilla/pdf.js/blob/master/extensions/firefox/components/PdfStreamConverter.js

[waddlesplash]

So where should I put the code that retrieves the header and how should viewer.js access it?

[yurydelendik]

look into getting Content-Disposition header somewhere at https://github.com/mozilla/pdf.js/blob/master/extensions/firefox/components/PdfStreamConverter.js#L582

[yurydelendik]

Since it's mostly for the extension, if possible, place all code into PdfStreamConverter.js

[waddlesplash]

Since it's mostly for the extension, if possible, place all code into PdfStreamConverter.js

But some code has to go into viewer.js for the download button, right?

[yurydelendik]

But some code has to go into viewer.js for the download button, right?

I don't see why, the code in the viewer.js just executes https://github.com/mozilla/pdf.js/blob/master/extensions/firefox/components/PdfStreamConverter.js#L235

[yurydelendik]

Fixed by #2635

[yurydelendik]

Ctrl+S part is dup of #943