Make sure downloaded files have a ".pdf" extension #2515
Conversation
|
Can someone preview & lint? |
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @jviereck received. Current queue size: 0 Live output at: http://107.22.172.223:8877/c1493e4aba918e1/output.txt |
|
/botio-windows lint |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/c1493e4aba918e1/output.txt Total script time: 0.21 mins Published |
From: Bot.io (Windows)ReceivedCommand cmd_lint from @jviereck received. Current queue size: 0 Live output at: http://107.22.172.223:8877/4bf6f3e5646b8f9/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/4bf6f3e5646b8f9/output.txt Total script time: 1.20 mins
|
|
Any changes I should make? |
| @@ -1024,8 +1024,16 @@ var PDFView = { | |||
| // function getDataSuccess(data) { | |||
| // var blob = PDFJS.createBlob(data.buffer, 'application/pdf'); | |||
| // var blobUrl = window.URL.createObjectURL(blob); | |||
| // var endOk = (url.toLowerCase().indexOf('.pdf', url.length - 4) !== -1); | |||
There was a problem hiding this comment.
What about the more concise:
// Append .pdf to the filename if it isn't already there
url += (url.toLowerCase().indexOf('.pdf', url.length - 4) !== -1) ? '.pdf' : ''There was a problem hiding this comment.
Now why didn't I think of that! 👍
|
OK, added the change @saebekassebil suggested and squashed. |
|
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @jviereck received. Current queue size: 0 Live output at: http://107.22.172.223:8877/dabaad54c30b696/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/dabaad54c30b696/output.txt Total script time: 0.29 mins Published |
|
@yurydelendik I appear to have gotten into something over my head... 😕. I just commited my WIP changes, which completely breaks downloading and nothing appears in the error log... What am I doing wrong here? |
|
The proper place to get content disposition will be near https://github.com/waddlesplash/pdf.js/blob/5eb7f171f66b2ccad144f7451f08f2660a144c06/extensions/firefox/components/PdfStreamConverter.js#L598 |
|
You can use |
|
@waddlesplash, thank you for looking into this issue. We will be releasing #2635 to fix the issue #2407. |
|
Thanks, @brendandahl and @yurydelendik. It would've taken me weeks to figure all that out. |
Partially addresses #2407. I couldn't find a way to get the HTTP headers without sending an
XMLHttpRequestand reading the headers sent back, but there are plenty of reasons to NOT do that.This patch simply ensures there is a
.pdfextension on the file (e.g if you are at a URL that ends in .php because a PHP script generated the PDF, this adds a .pdf to the file, so it is .php.pdf)