Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression from #2719 (3) #3133

Closed
vyv03354 opened this issue Apr 21, 2013 · 2 comments · Fixed by #3142
Closed

Regression from #2719 (3) #3133

vyv03354 opened this issue Apr 21, 2013 · 2 comments · Fixed by #3142
Labels
regression

Comments

@vyv03354
Copy link
Contributor

After #2719,
http://www.eiken.or.jp/eiken/apply/private/flow/pdf/ichiji.pdf
No longer displayed correctly. (Some texts are garbled.)
0.8.49 displayed it well.

I'm surprised reftest didn't catch the regression because this PDF is contained in the test.
@vyv03354
Copy link
Contributor Author

The original issue was #2877. Do we have to wait for something before constructing TilingPattern?

@mduan mduan mentioned this issue Apr 22, 2013
Merged
@mduan
Copy link
Contributor

mduan commented Apr 22, 2013

The above PR should fix this. The reason the reftest doesn't catch it is that it only happens if we draw the text layer, which the reftest doesn't do.

@mduan mduan closed this as completed Apr 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use same obj/font id counter for all partial evaluators on page mduan/pdf.js
2 participants
@mduan @vyv03354