-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use same obj/font id counter for all partial evaluators on page #3142
Conversation
/botio-windows preview |
From: Bot.io (Windows)ReceivedCommand cmd_preview from @mduan received. Current queue size: 0 Live output at: http://107.22.172.223:8877/7047e01f59eb038/output.txt |
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/7047e01f59eb038/output.txt Total script time: 0.22 mins Published |
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @mduan received. Current queue size: 0 Live output at: http://107.22.172.223:8877/90102a87f45923f/output.txt |
From: Bot.io (Linux)ReceivedCommand cmd_test from @mduan received. Current queue size: 0 Live output at: http://107.21.233.14:8877/edd437ccc12fe64/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/edd437ccc12fe64/output.txt Total script time: 21.89 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/90102a87f45923f/output.txt Total script time: 25.37 mins
|
@@ -159,17 +163,19 @@ var Page = (function PageClosure() { | |||
var contentStreamPromise = pdfManager.ensure(this, 'getContentStream', | |||
[]); | |||
var resourcesPromise = pdfManager.ensure(this, 'resources'); | |||
|
|||
var partialEvaluator = new PartialEvaluator( | |||
pdfManager, this.xref, handler, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: It looks like all these will be declared variables. Tab them in one more or bring pdfManager up a line and then align all params with that.
Addressed @brendandahl's comments. |
/botio test |
From: Bot.io (Linux)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.21.233.14:8877/52240d029e9e810/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @brendandahl received. Current queue size: 0 Live output at: http://107.22.172.223:8877/e70c494061356f3/output.txt |
From: Bot.io (Linux)SuccessFull output at http://107.21.233.14:8877/52240d029e9e810/output.txt Total script time: 21.79 mins
|
From: Bot.io (Windows)SuccessFull output at http://107.22.172.223:8877/e70c494061356f3/output.txt Total script time: 25.09 mins
|
Use same obj/font id counter for all partial evaluators on page
Fixes #3133.
The problem is that because of #2719,
PartialEvaluator.getOperatorList()
andPartialEvaluator.getTextContent()
can run interleaved. As a result we could be assigning the same dependency name to different images/fonts.