Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement options page for setting default preferences in Chromium extension #4560

Closed
Rob--W opened this issue Apr 3, 2014 · 5 comments · Fixed by #5619
Closed

Implement options page for setting default preferences in Chromium extension #4560

Rob--W opened this issue Apr 3, 2014 · 5 comments · Fixed by #5619

Comments

@Rob--W
Copy link
Member

Rob--W commented Apr 3, 2014

A nice-to-have.

The most commonly requested preferences are changing the default zoom level and the default hand tool setting.

@yurydelendik
Copy link
Contributor

See #3985

@Rob--W
Copy link
Member Author

Rob--W commented Apr 3, 2014

It'd be nice if the feature in #3985 is self-contained. Then it can be put on an options page, which is the Chromium way of configuring an extension.

@Snuffleupagus
Copy link
Collaborator

At the suggestion of @yurydelendik, I've started looking into implementing a preferences page for the Firefox versions of PDF.js.
One of my goals with this is that it should be as reusable as possible, so that it with a small effort could be used in e.g. the Chrome extension too.
I've just started working on this, hence I'm not sure when I'll have the first prototype done (but I'm hoping to have something to show next week).

@Rob--W
Copy link
Member Author

Rob--W commented Jun 3, 2014

I have already started with the implementation of preference management in
Chrome (integrated in the preferences module). Could you focus on the UI?

I'm writing user documentation for administrators and then I'll submit a PR.
On Jun 3, 2014 1:20 PM, "Jonas Jenwald" notifications@github.com wrote:

At the suggestion of @yurydelendik https://github.com/yurydelendik,
I've started looking into implementing a preferences page for the Firefox
versions of PDF.js.
One of my goals with this is that it should be as reusable as possible, so
that it with a small effort could be used in e.g. the Chrome extension too.
I've just started working on this, hence I'm not sure when I'll have the
first prototype done (but I'm hoping to have something to show next week).


Reply to this email directly or view it on GitHub
#4560 (comment).

@Snuffleupagus
Copy link
Collaborator

Given that the storage back-ends are different in Firefox and Chrome, I don't think that it should be much overlap there anyway. (And you would obviously still need to add Chrome specific code to preferences.js, so I'm hoping that what I'm doing can still be of some use in Chrome too.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants