Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggling the "Highlight all" search feature should not change the view position #5561

Closed
fkaelberer opened this issue Dec 18, 2014 · 1 comment
Labels

Comments

@fkaelberer
Copy link
Contributor

When the Highlight all search feature (checkbox in the demo, button in the extension) is toggled, then the view position seems to focus the first hit on the current page.
In my opinion, the toggle shouldn't move the view at all, especially if the user turns Highlight all off. Changing the focus is also contrary to Firefox's built-in highlight behavior (I haven't tested other browsers).

(FF34, Windows 7, current Demo version: 1.0.1011)

@jazzy-em
Copy link
Contributor

jazzy-em commented Feb 4, 2015

+1
I completely agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants