Display the index of the currently active search result in the matches counter of the findbar (issue 6993, bug 1062025) #10052
Conversation
Snuffleupagus
force-pushed
the
matchesCount
branch
from
d9f743f
to
0f4086c
Compare
Snuffleupagus
force-pushed
the
matchesCount
branch
2 times, most recently
from
7537d48
to
4c3acf2
Compare
Snuffleupagus
changed the title
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/4fdf1abe9c91916/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/4fdf1abe9c91916/output.txt Total script time: 7.39 mins Published |
…s counter of the findbar (issue 6993, bug 1062025) For the `PDFFindBar` implementation, similar to the native Firefox findbar, the matches count displayed is now limited to a (hopefully) reasonable value. *Please note:* In order to enable this feature in the `MOZCENTRAL` version, a follow-up patch will be required once this has landed in `mozilla-central`.
Snuffleupagus
force-pushed
the
matchesCount
branch
from
4c3acf2
to
c9a2564
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/eac56f1be815792/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/eac56f1be815792/output.txt Total script time: 7.59 mins Published |
| @@ -209,6 +209,10 @@ PDFViewerApplication.externalServices = { | |||
| FirefoxCom.request('updateFindControlState', data); | |||
| }, | |||
|
|
|||
| updateFindMatchesCount(data) { | |||
| // FirefoxCom.request('updateFindMatchesCount', data); | |||
There was a problem hiding this comment.
Note that this is purposely commented out, for now, since https://searchfox.org/mozilla-central/rev/37663bb87004167184de6f2afa6b05875eb0528e/browser/extensions/pdfjs/content/PdfStreamConverter.jsm#719,740 will throw without the mozilla-central follow-up patch.
|
Works really well. Thank you! |
For the
PDFFindBarimplementation, similar to the native Firefox findbar, the matches count displayed is now limited to a (hopefully) reasonable value; compare with https://searchfox.org/mozilla-central/rev/37663bb87004167184de6f2afa6b05875eb0528e/modules/libpref/init/all.js#1031Please note: In order to enable this feature in the
MOZCENTRALversion, a follow-up patch will be required once this has landed inmozilla-central.Fixes #6993.