Slightly improve the isSourcePDF parameter handling in JpegImage (PR 10031 follow-up)
#10063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…(PR 10031 follow-up) Currently there's only a single spot in the code-base where `JpegImage.getData` is called, however it nonetheless seem like a good idea to ensure during tests that the `isSourcePDF` parameter is correctly set. (Especially considering that the PDF use-cases will break without it.) Additionally, in `JpegImage._getLinearizedBlockData`, the code can be made a tiny bit more efficient by checking the value of `isSourcePDF` *first* to avoid useless checks (for the default PDF use-cases).
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/370f320dc82dd44/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.215.176.217:8877/59afe19429e45b5/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.215.176.217:8877/59afe19429e45b5/output.txt Total script time: 24.73 mins
Image differences available at: http://54.215.176.217:8877/59afe19429e45b5/reftest-analyzer.html#web=eq.log |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/370f320dc82dd44/output.txt Total script time: 36.04 mins
|
timvandermeij
approved these changes
Sep 12, 2018
|
Looks good to me. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently there's only a single spot in the code-base where
JpegImage.getDatais called, however it nonetheless seem like a good idea to ensure during tests that theisSourcePDFparameter is correctly set. (Especially considering that the PDF use-cases will break without it.)Additionally, in
JpegImage._getLinearizedBlockData, the code can be made a tiny bit more efficient by checking the value ofisSourcePDFfirst to avoid useless checks (for the default PDF use-cases).