-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to support plural forms in the matches counter of the findbar (issue 10067) #10070
Attempt to support plural forms in the matches counter of the findbar (issue 10067) #10070
Conversation
… (issue 10067) Based on a quick look at https://github.com/fabi1cazenave/webL10n/#pluralization, it seems that supporting plural forms shouldn't be as difficult as I first thought it might be.
14d9026
to
6c4157a
Compare
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/2648c6fe15560f3/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/2648c6fe15560f3/output.txt Total script time: 7.31 mins Published |
Looks good. Thank you! |
CC @Pike @zbraniecki Unfortunately this is not a complete fix. In order to allow locales to translate, you need to provide all forms in your .properties (one, two, few, many, other), not just the ones needed by English. webl10n is a relic from the past (Firefox OS), and had a very hacky plural support. It would be nice to take a look at Fluent, and see if PDF.js could be ported to that system (which is maintained, unlike webl10n). |
I'll create follow-up issues for both points. |
I don't understand this comment, since there shouldn't be anything preventing a non-English locale from adding whichever of the Also, keep in mind that as outlined in https://github.com/mozilla/pdf.js/blob/master/.github/CONTRIBUTING.md, the translations are imported from Firefox rather than maintained in this GitHub repo. |
Locales don't work in editors. They work in tools that let you translate a string only if it exists in the original source (en-US). If en-US doesn't have P.S. I manage localization for Firefox ;-) |
BTW, just realized that this should have landed with a new ID :-\ |
Based on a quick look at https://github.com/fabi1cazenave/webL10n/#pluralization, it seems that supporting plural forms shouldn't be as difficult as I first thought it might be.
Fixes #10067