When the search query changes, regardless of the search command, always re-calculate matches (bug 1030622) #10223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio-linux preview |
…ys re-calculate matches (bug 1030622) Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1030622
…ithout a `state` object Most of the code in `PDFFindController` assumes that a valid `state` always exits, hence it cannot hurt to add a simple check to avoid errors being thrown.
Snuffleupagus
force-pushed
the
find-reset-on-query-change
branch
from
46c5b15
to
06609b5
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.67.70.0:8877/57a4175f2a68688/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/57a4175f2a68688/output.txt Total script time: 3.29 mins Published |
timvandermeij
approved these changes
Nov 10, 2018
|
Thank you for improving this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1030622
Edit: When following the STR in https://bugzilla.mozilla.org/show_bug.cgi?id=1030622#c4, the problem occurs at step 6 since the automatic population of the findInput apparently doesn't trigger a find event.
Obviously this could, and maybe even should, be seen as a bug in Firefox itself, however it's easy enough to fix in PDF.js and the patch makes sense in general since
PDFFindController.executeCommandbecomes less sensitive to user error when called (e.g. in a custom viewer implementation).