Update BaseViewer.scrollPageIntoView to always validate the pageNumber parameter
#10245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mber` parameter Note that when e.g. presentation mode is active, we fail[1] to ensure that the `pageNumber` parameter is actually an integer before calling `_setCurrentPageNumber` (that method expects the argument be an integer). Also changes the method signature, of `scrollPageIntoView`, to use object destructuring instead. --- [1] Most likely, this is actually *my* oversight :-)
… modes in `BaseViewer` Given that the `_updateScrollMode`/`_updateSpreadMode` methods are "private", there's no particular reason to not just directly call `_setCurrentPageNumber`.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.67.70.0:8877/9ec90028e29dddf/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.67.70.0:8877/9ec90028e29dddf/output.txt Total script time: 2.99 mins Published |
timvandermeij
approved these changes
Nov 9, 2018
|
Looks good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that when e.g. presentation mode is active, we fail[1] to ensure that the
pageNumberparameter is actually an integer before calling_setCurrentPageNumber(that method expects the argument be an integer).Also changes the method signature, of
scrollPageIntoView, to use object destructuring instead.[1] Most likely, this is actually my oversight :-)