Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update eslint-plugin-mozilla to ^1.0.1 #10295

Merged
merged 1 commit into from
Dec 11, 2018
Merged

Update eslint-plugin-mozilla to ^1.0.1 #10295

merged 1 commit into from
Dec 11, 2018

Conversation

wojtekmaj
Copy link
Contributor

No description provided.

@timvandermeij
Copy link
Contributor

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/5088d0e6a3ab937/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/5b1f202df66a009/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/5b1f202df66a009/output.txt

Total script time: 1.24 mins

  • Lint: FAILED

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/5088d0e6a3ab937/output.txt

Total script time: 2.79 mins

  • Lint: Passed

@timvandermeij
Copy link
Contributor

timvandermeij commented Nov 23, 2018

This requires an update of nodejs on the bots, at least on the Linux bot. I asked on IRC if that can be done.

@timvandermeij
Copy link
Contributor

In the meantime, could you rebase this now that the other patches have been merged?

@timvandermeij
Copy link
Contributor

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/f65dcfbe8436fe9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/e81a56262a74fd9/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.67.70.0:8877/f65dcfbe8436fe9/output.txt

Total script time: 1.29 mins

  • Lint: FAILED

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/e81a56262a74fd9/output.txt

Total script time: 2.88 mins

  • Lint: Passed

@timvandermeij
Copy link
Contributor

timvandermeij commented Dec 10, 2018

@wojtekmaj Could you rebase this again? We should be good now since Node.js/NPM/Gulp got updated on the bots. In the meantime, 1.0.1 is released by the way.

@wojtekmaj
Copy link
Contributor Author

@timvandermeij Done :)

@wojtekmaj wojtekmaj changed the title Update eslint-plugin-mozilla to 1.0.0 Update eslint-plugin-mozilla to ^1.0.1 Dec 11, 2018
@timvandermeij
Copy link
Contributor

/botio lint

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/50aa73246e8f1f1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_lint from @timvandermeij received. Current queue size: 0

Live output at: http://54.215.176.217:8877/a90f2545b13c7c7/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/50aa73246e8f1f1/output.txt

Total script time: 0.77 mins

  • Lint: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.215.176.217:8877/a90f2545b13c7c7/output.txt

Total script time: 2.25 mins

  • Lint: Passed

@timvandermeij timvandermeij merged commit d9bf3d3 into mozilla:master Dec 11, 2018
@timvandermeij
Copy link
Contributor

Thank you for helping out with this!

@wojtekmaj wojtekmaj deleted the eslint-plugin-mozilla-update branch December 12, 2018 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants