Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small visual quirk in thumbnail viewer #10363

Merged
merged 2 commits into from
Dec 18, 2018
Merged

Fix small visual quirk in thumbnail viewer #10363

merged 2 commits into from
Dec 18, 2018

Conversation

tsilvap
Copy link
Contributor

@tsilvap tsilvap commented Dec 18, 2018

Remove the blue/red selection that would appear when you click a thumbnail in the thumbnail viewer in Firefox.

Fixes #10209

outline: 0;
}

#thumbnailView > a:focus {
Copy link
Collaborator

@Snuffleupagus Snuffleupagus Dec 18, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, is there a reason why these two blocks couldn't just be combined like so:

#thumbnailView > a:active,
#thumbnailView > a:focus {
  outline: 0;
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, is there a reason why these two blocks couldn't just be combined like so:

#thumbnailView > a:active,
#thumbnailView > a:focus {
  outline: 0;
}

No, there isn't, I forgot you could group selectors like that. Thanks!

@timvandermeij
Copy link
Contributor

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.67.70.0:8877/c0f24a3c4e126b1/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.67.70.0:8877/c0f24a3c4e126b1/output.txt

Total script time: 1.69 mins

Published

@timvandermeij timvandermeij merged commit 811c880 into mozilla:master Dec 18, 2018
@timvandermeij
Copy link
Contributor

Nice work!

@tsilvap tsilvap deleted the fix-thumbnail-quirk branch December 19, 2018 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants